Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reportLocation command not sending location in Manual mode #800

Closed
yakeer opened this issue Jul 25, 2024 · 15 comments
Closed

reportLocation command not sending location in Manual mode #800

yakeer opened this issue Jul 25, 2024 · 15 comments
Assignees

Comments

@yakeer
Copy link

yakeer commented Jul 25, 2024

Hey,
I'm using OwnTracks iOS in Manual Mode, with iOS 17.5.1. Location set to always,
Sending messages to a private MQTT Server (RabbitMQ) over the internet.

My HomeAssistant Mosquitto MQTT is bridged to the RabbitMQ.

I'm sending a reportLocation command,
And the app is not sending location, even if in foreground.

Is there a known issue?
Or am I doing something wrong?

@jpmens
Copy link
Member

jpmens commented Jul 25, 2024

I'm not sure reportLocation will work in Manual mode:

The user has to publish the current location explicitly via the UI. You use this if you want to (temporarily) avoid friends seeing where you are

Try seting the device in Significant Changes mode and try again. You'll also want to publish the request with qos>0

@ckrey
Copy link
Member

ckrey commented Jul 25, 2024

Show us the command and topic you are sending to. And show us your iOS config (sub, subTopic, sunQos, cmd, allowRemoteLocation)

@ckrey
Copy link
Member

ckrey commented Jul 25, 2024

And no, it is not responding in Manual mode

@ckrey
Copy link
Member

ckrey commented Jul 25, 2024

This is intended, not a bug

@yakeer
Copy link
Author

yakeer commented Jul 25, 2024

while writing you the config, I've seen the the cmd toggle is set to off.
turned it on and it works.

Maybe it's a good idea to put it default true.

Thank, and sorry.

@yakeer yakeer closed this as completed Jul 25, 2024
@yakeer
Copy link
Author

yakeer commented Jul 25, 2024

Btw, it's sending commands while in manual mode.

@jpmens
Copy link
Member

jpmens commented Jul 25, 2024

You wrote

it's sending commands while in manual mode

Do you mean the device is responding to a reportLocation while in Manual mode?

@ckrey
Copy link
Member

ckrey commented Jul 25, 2024

Then it is a bug!

@ckrey ckrey reopened this Jul 25, 2024
@ckrey ckrey self-assigned this Jul 25, 2024
@ckrey ckrey added the bug label Jul 25, 2024
@ckrey ckrey added the fixed label Jul 25, 2024
@yakeer
Copy link
Author

yakeer commented Jul 25, 2024

Well, that was a good bug for my application :)

Maybe it's better to add it as an option?
Whether to send commands in Manual mode?

@jpmens
Copy link
Member

jpmens commented Jul 25, 2024

It's not "sending commands"; it's responding to a reportLocation request, and no we won't add that as an option. When a user sets the device to Manual they don't wish to make it known where they are; hence we should not respond.

@jpmens
Copy link
Member

jpmens commented Jul 25, 2024

Also note, the bug has been fixed, and will no longer be there in the next version, so please don't rely on it!

@jpmens jpmens changed the title reportLocation command not sending location reportLocation command not sending location in Manual mode Jul 25, 2024
@yakeer
Copy link
Author

yakeer commented Jul 25, 2024

It's not "sending commands"; it's responding to a reportLocation request, and no we won't add that as an option. When a user sets the device to Manual they don't wish to make it known where they are; hence we should not respond.

My idea is to preserve battery as much as possible, and only send the location whenever requested.
Is there any other possible option to achieve that in a different manner?

@jpmens
Copy link
Member

jpmens commented Jul 25, 2024

I don't think you'll see a great battery consumption if you set the device to Significant Changes mode... Have you tried?

@jpmens
Copy link
Member

jpmens commented Jul 25, 2024

Over the last 10 days my iPhone 13 mini has consumed 15% battery on the "Home & Lock Screen" (!) with 5% in OwnTracks (Significant mode)

@ckrey
Copy link
Member

ckrey commented Sep 19, 2024

Fixed in version 18.0.1

@ckrey ckrey closed this as completed Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants