Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all target attributes to lower case #314

Closed
flabbergastedbd opened this issue Sep 5, 2014 · 1 comment
Closed

Change all target attributes to lower case #314

flabbergastedbd opened this issue Sep 5, 2014 · 1 comment
Assignees
@DePierre
Labels
Enhancement

Comments

@flabbergastedbd
Copy link
Contributor

Initially the target attributes dictionary had all caps so that legacy code is kept intact, but since all the api uses lower snake case, target attributes must also be made small. Changes will be required in lots of places
@flabbergastedbd flabbergastedbd added this to the v1.0 Mega Release milestone Sep 5, 2014
@DePierre DePierre self-assigned this Sep 6, 2014
DePierre added a commit that referenced this issue Sep 7, 2014
@DePierre
[target] Change ID to id (related #314).
3914fe9
DePierre added a commit that referenced this issue Sep 8, 2014
@DePierre
[target] Change PARTIAL_URL_OUTPUT_PATH to partial_url_output_path (#314
0de5281 
)
DePierre added a commit that referenced this issue Sep 8, 2014
@DePierre
[target] Change ALTERNATIVE_IPS to alternative_ips (#314)
09db834
DePierre added a commit that referenced this issue Sep 8, 2014
@DePierre
[target] Change PLUGIN_OUTPUT_DIR to plugin_output_dir (#314)
b28c999
DePierre added a commit that referenced this issue Sep 8, 2014
@DePierre
[target] Change MAX_XXX_RANK to max_xxx_rank (#314)
7360f14
DePierre added a commit that referenced this issue Sep 8, 2014
@DePierre
[target] Change IP_URL to ip_url (#314)
e56b2d4
DePierre added a commit that referenced this issue Sep 8, 2014
@DePierre
[target] Change TOP_DOMAIN to top_domain (#314)
5c3177e
DePierre added a commit that referenced this issue Sep 8, 2014
@DePierre
[target] Change TOP_URL to top_url (#314)
5e7a95f
DePierre added a commit that referenced this issue Sep 8, 2014
@DePierre
[target] Change SCOPE to scope (#314)
f71734a
DePierre added a commit that referenced this issue Sep 8, 2014
@DePierre
[target] Change HOST_IP to host_ip (#314)
b573024
DePierre added a commit that referenced this issue Sep 8, 2014
@DePierre
[target] Change HOST_NAME to host_name (#314)
c0aa1b2
DePierre added a commit that referenced this issue Sep 8, 2014
@DePierre
[target] Change HOST_PATH to host_path (#314)
f7b1fae
DePierre added a commit that referenced this issue Sep 8, 2014
@DePierre
[target] Change XXX_OUTPUT to xxx_output (#314)
13ec603
DePierre added a commit that referenced this issue Sep 8, 2014
@DePierre
[target] Change PORT_NUMBER to port_number (#314)
9af785f
DePierre added a commit that referenced this issue Sep 8, 2014
@DePierre
[target] Change TARGET_URL to target_url (#314)
0cd3732
@DePierre
Copy link
Contributor

DePierre commented Sep 8, 2014

All target's attributes are now in lower case (if I didn't forget one).

@DePierre DePierre closed this as completed Sep 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DePierre DePierre

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DePierre @flabbergastedbd