Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show less functionality added to optimize the click flow #643

Merged
merged 2 commits into from
Apr 2, 2016
Merged

Show less functionality added to optimize the click flow #643

merged 2 commits into from
Apr 2, 2016

Conversation

saganshul
Copy link
Contributor

This PR is small optimization in reference to issue #429.

Description

Added a show less button at bottom, on clicking it Plugin gets collapse and auto scroll smoothly to plugin next to it. This will decrease a lot of vertical scrolling.

Related Issue

#429

Motivation and Context

This will decrease a lot of vertical scrolling.

Reviewers

@delta24 @7a @DePierre

How Has This Been Tested?

This was tested on Firefox and Chromium and works as very well on both browsers.

Screenshots (if appropriate):

screenshot from 2016-03-30 22-02-34

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other

Checklist:

  • My code follows the code style (modified PEP8) of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@viyatb
Copy link
Member

viyatb commented Apr 2, 2016

@saganshul Right now on clicking the accordion element, the previous accordion automatically collapses to show the next one. How does this decrease vertical scrolling?

@saganshul
Copy link
Contributor Author

@delta24, suppose I do not want to review next plugin so to collapse the detailed plugin, I have to back scroll to plugin and click it. Hence now if there is "show less" at bottom of expanded plugin. User can just click and can collapse plugin.

@viyatb
Copy link
Member

viyatb commented Apr 2, 2016

@saganshul Then IMO a more apt name for "Show less" would be "Close plugin" or "Collapse" or something like that.

@saganshul
Copy link
Contributor Author

@delta24 correct, I will change the name and update the PR.

@saganshul
Copy link
Contributor Author

@delta24 done .Please review

@viyatb viyatb merged commit 5d6748b into owtf:develop Apr 2, 2016
viyatb added a commit that referenced this pull request May 6, 2016
* Missing "</a" element caused the whole accordion treated as a link
  and would collapse the accordion on clicking any resource link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants