Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set plugin group to web if not specified, fixes #390 #659

Merged
merged 1 commit into from
Apr 18, 2016

Conversation

DarKnight24
Copy link
Contributor

This PR sets the plugin group to web if not specified. This makes -t command functional.

Description

Set the plugin_group to web if not specified.

Related Issue

#390

Motivation and Context

Reviewers

@delta24

How Has This Been Tested?

./owtf.py -t passive

Screenshots (if appropriate):

screenshot from 2016-04-14 11 33 19

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other

Checklist:

  • My code follows the code style (modified PEP8) of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@@ -54,7 +54,7 @@ def process_options(user_args):

# Default settings:
profiles = {}
plugin_group = arg.PluginGroup
plugin_group = arg.PluginGroup or 'web'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment here which explains the "or" statement :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the command line option -g is passed the plugin_group will be set to the specified group, else None is set in arg.PluginGroup. In the case if no group is specified we set it to web to make -t functional with web plugin_group. The default is set to web as discussed in issue #390 .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant in the code. xD

@DarKnight24 DarKnight24 force-pushed the fix_390 branch 2 times, most recently from df48497 to 41e256a Compare April 14, 2016 09:53
@DePierre
Copy link
Contributor

I tested the changes and it seems to properly fix #390, although #375 is still unfixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants