Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tsconfig self-reference throw error #211

Merged
merged 2 commits into from
Jul 2, 2024
Merged

fix: tsconfig self-reference throw error #211

merged 2 commits into from
Jul 2, 2024

Conversation

jerrykingxyz
Copy link
Contributor

Self-reference in tsconfig will cause short-lived invaild cache, more info see #210.

This PR will throw a TsconfigSelfReference error.

jerrykingxyz
jerrykingxyz commented Jul 2, 2024
View reviewed changes
src/error.rs Outdated Show resolved Hide resolved
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 2, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #211 will not alter performance

Comparing jerrykingxyz:tsconfig (6c4e192) with main (a662c98)

Summary

✅ 2 untouched benchmarks

@Boshen Boshen self-assigned this Jul 2, 2024
@Boshen Boshen merged commit 2c98773 into oxc-project:main Jul 2, 2024
18 checks passed
@chenjiahan chenjiahan mentioned this pull request Jul 3, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Boshen Boshen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerrykingxyz @Boshen