Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(napi): make napi binary smaller with minimal tracing features #213

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jul 3, 2024

703K -> 687K

@Boshen Boshen force-pushed the smaller-tracing branch from a974828 to 4833625 Compare July 3, 2024 15:00
Copy link

codspeed-hq bot commented Jul 3, 2024

CodSpeed Performance Report

Merging #213 will not alter performance

Comparing smaller-tracing (4833625) with main (09da311)

Summary

✅ 2 untouched benchmarks

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (09da311) to head (4833625).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          11       11           
  Lines        2306     2306           
=======================================
  Hits         2235     2235           
  Misses         71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Boshen Boshen merged commit 990b96d into main Jul 3, 2024
21 checks passed
@Boshen Boshen deleted the smaller-tracing branch July 3, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant