fix: tsconfig paths should not be applied to paths inside node_modules

[Boshen]

Found this case while working on tsconfig discovered.

Still uncertain about this change but the original test returns not found.

https://github.com/parcel-bundler/parcel/blob/b6224fd519f95e68d8b93ba90376fd94c8b76e69/packages/utils/node-resolver-rs/src/lib.rs#L2372-L2384

It should not pick up any tsconfig while resolving specifier inside node_modules.

oxc-resolver/fixtures/tsconfig/node_modules/tsconfig-not-used/tsconfig.json

Line 4 in 19902fb

"ts-path": ["foo.js"]

Reference:

• https://github.com/aleclarson/vite-tsconfig-paths/blob/master/src/index.ts
• https://github.com/jonaskello/tsconfig-paths-webpack-plugin/blob/master/src/plugin.ts

The webpack plugin has no mention of node_modules but the vite plugin does.

@sapphi-red I'm not confident with this logic overall so assigning you to review.

[graphite-app]

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.19%. Comparing base (dc46713) to head (5654bce).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #760   +/-   ##
=======================================
  Coverage   94.18%   94.19%           
=======================================
  Files          16       16           
  Lines        3028     3031    +3     
=======================================
+ Hits         2852     2855    +3     
  Misses        176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[codspeed-hq]

CodSpeed Performance Report

Merging #760 will not alter performance

_{Comparing 10-17-fix_tsconfig_paths_should_not_be_applied_to_paths_inside_node_modules (5654bce) with main (dc46713)}

Summary

✅ 7 untouched
⏩ 2 skipped¹

Footnotes

1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[sapphi-red]

I think this makes sense.
esbuild 0.18.0+ also ignores tsconfig paths in node_modules.
https://github.com/evanw/esbuild/blob/main/CHANGELOG-2023.md#0180:~:text=Ignore%20all%20tsconfig,ignoring%20certain%20settings.

[Boshen]

Merge activity

• Oct 17, 5:18 AM UTC: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 17, 5:18 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Oct 17, 5:22 AM UTC: Merged by the Graphite merge queue.