refactor: do not store is_symlink in CachedPathImpl

[Boshen]

std::fs::metadata always return is_symlink: false so it's confusing
and pointless to store it in CachedPathImpl

[Boshen]

• refactor: do not store is_symlink in CachedPathImpl #850 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.84%. Comparing base (3a9d5e7) to head (be1e1b4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
+ Coverage   93.82%   93.84%   +0.01%     
==========================================
  Files          17       17              
  Lines        3079     3085       +6     
==========================================
+ Hits         2889     2895       +6     
  Misses        190      190              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Boshen]

Merge activity

• Nov 18, 8:36 AM UTC: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Nov 18, 8:40 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Nov 18, 8:43 AM UTC: Merged by the Graphite merge queue.

[codspeed-hq]

CodSpeed Performance Report

Merging #850 will not alter performance

_{Comparing 11-18-refactor_do_not_store_is_symlink_in_cachedpathimpl (be1e1b4) with main (3a9d5e7)¹}

Summary

✅ 11 untouched
⏩ 5 skipped²

Footnotes

1. No successful run was found on main (be1e1b4) during the generation of this report, so 3a9d5e7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩