Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 27, 2025

fixes of #872

The solution is not optimal, I spent the whole day trying to understand synchronization but couldn't figure it out, so resorting to this really bad implementation.

The good news is that I came up with a simple failing test for future improvements.

@graphite-app
Copy link

graphite-app bot commented Nov 27, 2025

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 27, 2025

CodSpeed Performance Report

Merging #879 will degrade performances by 4.77%

Comparing clear_cache (2492bd2) with main (9b82017)1

Summary

⚡ 1 improvement
❌ 1 regression
✅ 10 untouched
⏩ 5 skipped2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
small 11.6 µs 11.2 µs +4%
resolver_real[multi-thread] 469.6 µs 493.1 µs -4.77%

Footnotes

  1. No successful run was found on main (2492bd2) during the generation of this report, so 9b82017 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen changed the title test: add clear_cache race condition test fix: store PathBuf with weak pointers to handle cache clearing Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.39%. Comparing base (6887252) to head (2492bd2).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/cache/cache_impl.rs 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
+ Coverage   94.36%   94.39%   +0.02%     
==========================================
  Files          17       17              
  Lines        3230     3247      +17     
==========================================
+ Hits         3048     3065      +17     
  Misses        182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Boshen Boshen marked this pull request as ready for review November 27, 2025 15:01
@Boshen Boshen added the merge label Nov 27, 2025
Copy link
Member Author

Boshen commented Nov 27, 2025

Merge activity

fixes of #872

The solution is not optimal, I spent the whole day trying to understand synchronization but couldn't figure it out, so resorting to this really bad implementation.

The good news is that I came up with a simple failing test for future improvements.
@graphite-app graphite-app bot merged commit 2492bd2 into main Nov 27, 2025
17 checks passed
@graphite-app graphite-app bot deleted the clear_cache branch November 27, 2025 15:13
@Boshen Boshen mentioned this pull request Nov 27, 2025
@graphite-app graphite-app bot removed the merge label Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants