-
-
Notifications
You must be signed in to change notification settings - Fork 35
fix: store PathBuf with weak pointers to handle cache clearing #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd the label merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Performance ReportMerging #879 will degrade performances by 4.77%Comparing Summary
Benchmarks breakdown
Footnotes
|
clear_cache race condition test
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
==========================================
+ Coverage 94.36% 94.39% +0.02%
==========================================
Files 17 17
Lines 3230 3247 +17
==========================================
+ Hits 3048 3065 +17
Misses 182 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merge activity
|
fixes of #872 The solution is not optimal, I spent the whole day trying to understand synchronization but couldn't figure it out, so resorting to this really bad implementation. The good news is that I came up with a simple failing test for future improvements.
3258233 to
2492bd2
Compare
fixes of #872
The solution is not optimal, I spent the whole day trying to understand synchronization but couldn't figure it out, so resorting to this really bad implementation.
The good news is that I came up with a simple failing test for future improvements.