set rule category to suspicious

oxc-project · Aug 31, 2024 · 113eaf9 · 113eaf9
1 parent abba6f2
commit 113eaf9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/crates/oxc_linter/src/rules/oxc/no_async_endpoint_handlers.rs b/crates/oxc_linter/src/rules/oxc/no_async_endpoint_handlers.rs
@@ -165,7 +165,7 @@ declare_oxc_lint!(
     /// }
     /// ```
     NoAsyncEndpointHandlers,
-    restriction
+    suspicious
 );
 
 impl Rule for NoAsyncEndpointHandlers {
@@ -350,7 +350,7 @@ fn test() {
         ),
         (
             "
-            const foo = async foo => (req, res) {}
+            const foo = async (req, res) => {}
             app.post('/', foo)
             ",
             None,

diff --git a/crates/oxc_linter/src/snapshots/no_async_endpoint_handlers.snap b/crates/oxc_linter/src/snapshots/no_async_endpoint_handlers.snap
@@ -54,14 +54,18 @@ source: crates/oxc_linter/src/tester.rs
    ╰────
   help: Express <= 4.x does not handle Promise rejections. Use `new Promise((resolve, reject) => { ... }).catch(next)` instead.
 
-  × Expected a semicolon or an implicit semicolon after a statement, but found none
-   ╭─[no_async_endpoint_handlers.tsx:2:48]
+  ⚠ oxc(no-async-endpoint-handlers): Express endpoint handlers should not be async.
+   ╭─[no_async_endpoint_handlers.tsx:3:27]
  1 │ 
- 2 │             const foo = async foo => (req, res) {}
-   ·                                                ▲
+ 2 │             const foo = async (req, res) => {}
+   ·                         ──┬──
+   ·                           ╰── Async handler is declared here
  3 │             app.post('/', foo)
+   ·                           ─┬─
+   ·                            ╰── and is registered here
+ 4 │             
    ╰────
-  help: Try insert a semicolon here
+  help: Express <= 4.x does not handle Promise rejections. Use `new Promise((resolve, reject) => { ... }).catch(next)` instead.
 
   ⚠ oxc(no-async-endpoint-handlers): Express endpoint handlers should not be async.
    ╭─[no_async_endpoint_handlers.tsx:3:21]