fix(minifier): ~~ operator should only work on numbers (#6598)

oxc-project · Oct 15, 2024 · 389d261 · 389d261
1 parent ba385fc
commit 389d261
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/crates/oxc_minifier/src/ast_passes/peephole_fold_constants.rs b/crates/oxc_minifier/src/ast_passes/peephole_fold_constants.rs
@@ -210,7 +210,7 @@ impl<'a, 'b> PeepholeFoldConstants {
                 }),
                 Expression::UnaryExpression(un) => {
                     match un.operator {
-                        UnaryOperator::BitwiseNot => {
+                        UnaryOperator::BitwiseNot if un.argument.is_number() => {
                             // Return the un-bitten value
                             Some(ctx.ast.move_expression(&mut un.argument))
                         }
@@ -1466,6 +1466,7 @@ mod test {
         test("a=~~0", "a=0");
         test("a=~~10", "a=10");
         test("a=~-7", "a=6");
+        test_same("a=~~foo()");
 
         // test("a=+true", "a=1");
         test("a=+10", "a=10");

diff --git a/tasks/minsize/minsize.snap b/tasks/minsize/minsize.snap
@@ -2,21 +2,21 @@ Original   | Minified   | esbuild    | Gzip       | esbuild
 
 72.14 kB   | 24.12 kB   | 23.70 kB   | 8.62 kB    | 8.54 kB    | react.development.js
 
-173.90 kB  | 61.67 kB   | 59.82 kB   | 19.53 kB   | 19.33 kB   | moment.js 
+173.90 kB  | 61.68 kB   | 59.82 kB   | 19.55 kB   | 19.33 kB   | moment.js 
 
 287.63 kB  | 92.70 kB   | 90.07 kB   | 32.27 kB   | 31.95 kB   | jquery.js 
 
 342.15 kB  | 121.90 kB  | 118.14 kB  | 44.59 kB   | 44.37 kB   | vue.js    
 
 544.10 kB  | 73.49 kB   | 72.48 kB   | 26.13 kB   | 26.20 kB   | lodash.js 
 
-555.77 kB  | 276.31 kB  | 270.13 kB  | 91.08 kB   | 90.80 kB   | d3.js     
+555.77 kB  | 276.31 kB  | 270.13 kB  | 91.09 kB   | 90.80 kB   | d3.js     
 
 1.01 MB    | 467.63 kB  | 458.89 kB  | 126.75 kB  | 126.71 kB  | bundle.min.js
 
 1.25 MB    | 662.90 kB  | 646.76 kB  | 164.00 kB  | 163.73 kB  | three.js  
 
-2.14 MB    | 741.41 kB  | 724.14 kB  | 181.41 kB  | 181.07 kB  | victory.js
+2.14 MB    | 741.42 kB  | 724.14 kB  | 181.41 kB  | 181.07 kB  | victory.js
 
 3.20 MB    | 1.02 MB    | 1.01 MB    | 331.95 kB  | 331.56 kB  | echarts.js