refactor(semantic): add strict mode in scope flags for class definitions

oxc-project · Jul 10, 2024 · 45430cd · 45430cd
1 parent b632c04
commit 45430cd
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/crates/oxc_semantic/src/builder.rs b/crates/oxc_semantic/src/builder.rs
@@ -258,7 +258,6 @@ impl<'a> SemanticBuilder<'a> {
 
     pub fn strict_mode(&self) -> bool {
         self.current_scope_flags().is_strict_mode()
-            || self.current_node_flags.contains(NodeFlags::Class)
     }
 
     pub fn set_function_node_flag(&mut self, flag: NodeFlags) {
@@ -421,6 +420,12 @@ impl<'a> Visit<'a> for SemanticBuilder<'a> {
             if flags.contains(ScopeFlags::Top) { None } else { Some(self.current_scope_id) };
 
         let mut flags = flags;
+
+        if !flags.is_strict_mode() && self.current_node_flags.has_class() {
+            // NOTE A class definition is always strict mode code.
+            flags |= ScopeFlags::StrictMode;
+        };
+
         if let Some(parent_scope_id) = parent_scope_id {
             flags = self.scope.get_new_scope_flags(flags, parent_scope_id);
         }