Skip to content

Commit 6ec0778

Browse files
ci(benchmarks): disable mangler benchmarks (#12118)
Related to #11347. Mangler benchmarks display so much variance that they're pretty useless. Valiant attempts to reduce the variance (#11408, #11409) have not worked, and contributors have been getting confused by the bonkers "Performance regressed 13%" alerts on unrelated PRs. No one is working on mangler at the moment, so just disable the damn things!
1 parent f7c675d commit 6ec0778

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

tasks/benchmark/benches/minifier.rs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ fn bench_minifier(criterion: &mut Criterion) {
5050
group.finish();
5151
}
5252

53+
#[expect(dead_code)]
5354
fn bench_mangler(criterion: &mut Criterion) {
5455
let mut group = criterion.benchmark_group("mangler");
5556
for file in TestFiles::minimal().files() {
@@ -75,5 +76,9 @@ fn bench_mangler(criterion: &mut Criterion) {
7576
group.finish();
7677
}
7778

78-
criterion_group!(minifier, bench_minifier, bench_mangler);
79+
// Mangler benchmark disabled, as it displays too much variance to be useful.
80+
// e.g. this PR does not touch the mangler, but shows a 13% regression on mangler benchmark:
81+
// https://github.com/oxc-project/oxc/pull/12106
82+
// criterion_group!(minifier, bench_minifier, bench_mangler);
83+
criterion_group!(minifier, bench_minifier);
7984
criterion_main!(minifier);

0 commit comments

Comments
 (0)