Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 7, 2025

Related to #11347.

Mangler benchmarks display so much variance that they're pretty useless. Valiant attempts to reduce the variance (#11408, #11409) have not worked, and contributors have been getting confused by the bonkers "Performance regressed 13%" alerts on unrelated PRs.

No one is working on mangler at the moment, so just disable the damn things!

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 7, 2025

CodSpeed Instrumentation Performance Report

Merging #12118 will not alter performance

Comparing 07-07-ci_benchmarks_disable_mangler_benchmarks (8cb5c70) with main (349d395)

Summary

✅ 34 untouched benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ mangler[RadixUIAdoptionSection.jsx] 14.6 µs N/A N/A
⁉️ mangler[binder.ts] 805.3 µs N/A N/A
⁉️ mangler[cal.com.tsx] 3.1 ms N/A N/A
⁉️ mangler[react.development.js] 283.8 µs N/A N/A

@overlookmotel overlookmotel marked this pull request as ready for review July 7, 2025 11:13
@Boshen Boshen merged commit 6ec0778 into main Jul 7, 2025
26 checks passed
@Boshen Boshen deleted the 07-07-ci_benchmarks_disable_mangler_benchmarks branch July 7, 2025 13:47
Boshen added a commit that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants