refactor: don't inline all structs.

oxc-project · Jul 2, 2024 · 7509233 · 7509233
1 parent 7db9dde
commit 7509233
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/crates/oxc_ast/src/generated/visit.rs b/crates/oxc_ast/src/generated/visit.rs
@@ -2961,7 +2961,6 @@ pub mod walk {
         }
     }
 
-    #[inline]
     pub fn walk_class<'a, V: Visit<'a>>(visitor: &mut V, it: &Class<'a>) {
         let kind = AstKind::Class(visitor.alloc(it));
         visitor.enter_node(kind);
@@ -3057,7 +3056,6 @@ pub mod walk {
         visitor.leave_node(kind);
     }
 
-    #[inline]
     pub fn walk_function<'a, V: Visit<'a>>(
         visitor: &mut V,
         it: &Function<'a>,

diff --git a/crates/oxc_ast/src/generated/visit_mut.rs b/crates/oxc_ast/src/generated/visit_mut.rs
@@ -3086,7 +3086,6 @@ pub mod walk_mut {
         }
     }
 
-    #[inline]
     pub fn walk_class<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut Class<'a>) {
         let kind = AstType::Class;
         visitor.enter_node(kind);
@@ -3182,7 +3181,6 @@ pub mod walk_mut {
         visitor.leave_node(kind);
     }
 
-    #[inline]
     pub fn walk_function<'a, V: VisitMut<'a>>(
         visitor: &mut V,
         it: &mut Function<'a>,

diff --git a/tasks/ast_codegen/src/generators/visit.rs b/tasks/ast_codegen/src/generators/visit.rs
@@ -632,8 +632,8 @@ impl<'a> VisitBuilder<'a> {
             _ => body,
         };
 
-        // always inline struct walks
-        (result, true)
+        // inline if there are 5 or less fields.
+        (result, fields_visits.len() <= 5)
     }
 
     fn analyze_type(&self, ty: &Type) -> Option<(TypeRef, TypeWrapper)> {