test(linter/no-useless-constructor): add cases for initializers in su…

…bclass constructors (#6390)
oxc-project · Oct 9, 2024 · 84aa2a2 · 84aa2a2
1 parent 5ea9ef7
commit 84aa2a2
Showing 1 changed file with 41 additions and 0 deletions.
diff --git a/crates/oxc_linter/src/rules/eslint/no_useless_constructor.rs b/crates/oxc_linter/src/rules/eslint/no_useless_constructor.rs
@@ -287,6 +287,47 @@ fn test() {
         "class A { constructor(readonly x: number) {} }",
         "class A { constructor(private readonly x: number) {} }",
         "class A extends B { constructor(override x: number) { super(x); } }",
+        "
+        class A {
+            protected foo: number | undefined;
+            constructor(foo?: number) {
+                this.foo = foo;
+            }
+        }
+        class B extends A {
+            protected foo: number;
+            constructor(foo: number = 0) {
+                super(foo);
+            }
+        }
+        ",
+        "
+        class A {
+            protected foo: number | undefined;
+            constructor(foo?: number) {
+                this.foo = foo;
+            }
+        }
+        class B extends A {
+            constructor(foo?: number) {
+                super(foo ?? 0);
+            }
+        }
+        ",
+        // TODO: type aware linting :(
+        // "
+        // class A {
+        //     protected foo: string;
+        //     constructor(foo: string) {
+        //         this.foo = foo;
+        //     }
+        // }
+        // class B extends A {
+        //     constructor(foo: 'a' | 'b') {
+        //         super(foo);
+        //     }
+        // }
+        // ",
     ];
 
     let fail = vec![