fix(oxc_linter): Make linter file paths clickable within JetBrains terminals

JetBrains terminals don't work reliably with relative paths to hyperlink to the file. Outputting the full file URL instead works consistently.

Author: nrayburn-tech

Cargo.lock

@@ -228,6 +228,7 @@ tokio = { version = "1.45.1", default-features = false }
 tower-lsp-server = "0.21.1"
 tracing-subscriber = "0.3.19"
 ureq = { version = "3.0.11", default-features = false }
+url = "2.5.4"
 walkdir = "2.5.0"
 
 [workspace.metadata.cargo-shear]

Cargo.toml

@@ -21,3 +21,4 @@ doctest = false
 [dependencies]
 cow-utils = { workspace = true }
 miette = { workspace = true }
+url = { workspace = true }

crates/oxc_diagnostics/Cargo.toml

@@ -4,8 +4,8 @@ use std::{
     sync::{Arc, mpsc},
 };
 
-use cow_utils::CowUtils;
 use miette::LabeledSpan;
+use url::Url;
 
 use crate::{
     Error, NamedSource, OxcDiagnostic, Severity,
@@ -128,17 +128,27 @@ impl DiagnosticService {
     /// Wrap [diagnostics] with the source code and path, converting them into [Error]s.
     ///
     /// [diagnostics]: OxcDiagnostic
-    pub fn wrap_diagnostics<P: AsRef<Path>>(
+    pub fn wrap_diagnostics<C: AsRef<Path>, P: AsRef<Path>>(
+        cwd: C,
         path: P,
         source_text: &str,
         source_start: u32,
         diagnostics: Vec<OxcDiagnostic>,
-    ) -> (PathBuf, Vec<Error>) {
-        let path = path.as_ref();
-        let path_display = path.to_string_lossy();
-        // replace windows \ path separator with posix style one
-        // reflects what eslint is outputting
-        let path_display = path_display.cow_replace('\\', "/");
+    ) -> Vec<Error> {
+        #[cfg(test)]
+        let is_jetbrains_terminal = false;
+        #[cfg(not(test))]
+        let is_jetbrains_terminal = std::env::var("TERMINAL_EMULATOR").is_ok_and(|x| x.eq("JetBrains-JediTerm"));
+
+        let file_url = Url::from_file_path(path.as_ref());
+        let path_display = if is_jetbrains_terminal && file_url.is_ok() {
+            file_url.unwrap().to_string()
+        } else {
+            let path = path.as_ref().strip_prefix(cwd).unwrap_or(path.as_ref());
+            // replace windows \ path separator with posix style one
+            // reflects what eslint is outputting
+            path.to_string_lossy().replace('\\', "/")
+        };
 
         let source = Arc::new(NamedSource::new(path_display, source_text.to_owned()));
         let diagnostics = diagnostics
@@ -167,7 +177,7 @@ impl DiagnosticService {
                 }
             })
             .collect();
-        (path.to_path_buf(), diagnostics)
+        diagnostics
     }
 
     /// # Panics

crates/oxc_diagnostics/src/service.rs

@@ -522,14 +522,14 @@ impl<'l> Runtime<'l> {
 
                         if !messages.is_empty() {
                             let errors = messages.into_iter().map(Into::into).collect();
-                            let path = path.strip_prefix(&me.cwd).unwrap_or(path);
                             let diagnostics = DiagnosticService::wrap_diagnostics(
+                                &me.cwd,
                                 path,
                                 &owner.source_text,
                                 section.source.start,
                                 errors,
                             );
-                            tx_error.send(Some(diagnostics)).unwrap();
+                            tx_error.send(Some((path.to_path_buf(), diagnostics))).unwrap();
                         }
                     }
                     // If the new source text is owned, that means it was modified,