fix(codegen): invalid codegen when in inside bin expr in or loop

oxc-project · Oct 10, 2024 · e44af02 · e44af02
1 parent 2531490
commit e44af02
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/crates/oxc_codegen/src/gen.rs b/crates/oxc_codegen/src/gen.rs
@@ -1740,7 +1740,7 @@ impl<'a> GenExpr for LogicalExpression<'a> {
             precedence,
             ctx,
             left_precedence: Precedence::Lowest,
-            left_ctx: Context::empty(),
+            left_ctx: ctx,
             operator: BinaryishOperator::Logical(self.operator),
             wrap: false,
             right_precedence: Precedence::Lowest,

diff --git a/crates/oxc_codegen/tests/integration/unit.rs b/crates/oxc_codegen/tests/integration/unit.rs
@@ -279,4 +279,9 @@ fn in_expr_in_sequence_in_for_loop_init() {
         "for (l = ('foo' in bar), i; i < 10; i += 1) {}",
         "for (l = (\"foo\" in bar), i; i < 10; i += 1) {}\n",
     );
+
+    test(
+        "for (('hidden' in a) && (m = a.hidden), r = 0; s > r; r++) {}",
+        "for ((\"hidden\" in a) && (m = a.hidden), r = 0; s > r; r++) {}\n",
+    );
 }