Skip to content

linter: unicorn/switch-case-braces not applying defaults when enabled via categories #12532

@KieranP

Description

@KieranP

What version of Oxlint are you using?

1.8.0

What command did you run?

oxlint src/**/*.{js,ts}

What does your .oxlintrc.json config file look like?

{
  "$schema": "./node_modules/oxlint/configuration_schema.json",
  "plugins": ["eslint", "oxc", "typescript", "import", "promise", "unicorn"],
  "categories": {
    "correctness": "error",
    "nursery": "error",
    "pedantic": "error",
    "perf": "error",
    "restriction": "error",
    "style": "error",
    "suspicious": "error"
  }
}

What happened?

I have enabled specific plugins, and within those plugins, enabled rules for all categories available.

Running oxlint --print-config shows the following:

{
  "plugins": [
    "unicorn",
    "typescript",
    "oxc",
    "import",
    "promise"
  ],
  "categories": {
    "correctness": "deny",
    "perf": "deny",
    "restriction": "deny",
    "suspicious": "deny",
    "nursery": "deny",
    "style": "deny",
    "pedantic": "deny"
  },
  "rules": {
    "array-callback-return": "deny",
    "arrow-body-style": "deny",
    "block-scoped-var": "deny",
    "curly": "deny",
    "default-case": "deny",
    "default-case-last": "deny",
    "default-param-last": "deny",
    "eqeqeq": "deny",
    "for-direction": "deny",
    "func-names": "deny",
    "func-style": "deny",
    "getter-return": "deny",
    "grouped-accessor-pairs": "deny",
    "guard-for-in": "deny",
    "id-length": "deny",
    "init-declarations": "deny",
    "max-classes-per-file": "deny",
    "max-depth": "deny",
    "max-lines": "deny",
    "max-lines-per-function": "deny",
    "max-nested-callbacks": "deny",
    "max-params": "deny",
    "new-cap": "deny",
    "no-alert": "deny",
    "no-array-constructor": "deny",
    "no-async-promise-executor": "deny",
    "no-await-in-loop": "deny",
    "no-bitwise": "deny",
    "no-caller": "deny",
    "no-case-declarations": "deny",
    "no-class-assign": "deny",
    "no-compare-neg-zero": "deny",
    "no-cond-assign": "deny",
    "no-console": "deny",
    "no-const-assign": "deny",
    "no-constant-binary-expression": "deny",
    "no-constant-condition": "deny",
    "no-constructor-return": "deny",
    "no-continue": "deny",
    "no-control-regex": "deny",
    "no-debugger": "deny",
    "no-delete-var": "deny",
    "no-div-regex": "deny",
    "no-dupe-class-members": "deny",
    "no-dupe-else-if": "deny",
    "no-dupe-keys": "deny",
    "no-duplicate-case": "deny",
    "no-duplicate-imports": "deny",
    "no-else-return": "deny",
    "no-empty": "deny",
    "no-empty-character-class": "deny",
    "no-empty-function": "deny",
    "no-empty-pattern": "deny",
    "no-empty-static-block": "deny",
    "no-eq-null": "deny",
    "no-eval": "deny",
    "no-ex-assign": "deny",
    "no-extend-native": "deny",
    "no-extra-bind": "deny",
    "no-extra-boolean-cast": "deny",
    "no-extra-label": "deny",
    "no-fallthrough": "deny",
    "no-func-assign": "deny",
    "no-global-assign": "deny",
    "no-import-assign": "deny",
    "no-inner-declarations": "deny",
    "no-invalid-regexp": "deny",
    "no-irregular-whitespace": "deny",
    "no-iterator": "deny",
    "no-label-var": "deny",
    "no-labels": "deny",
    "no-lone-blocks": "deny",
    "no-lonely-if": "deny",
    "no-loss-of-precision": "deny",
    "no-magic-numbers": "deny",
    "no-multi-assign": "deny",
    "no-multi-str": "deny",
    "no-negated-condition": "deny",
    "no-nested-ternary": "deny",
    "no-new": "deny",
    "no-new-func": "deny",
    "no-new-native-nonconstructor": "deny",
    "no-new-wrappers": "deny",
    "no-nonoctal-decimal-escape": "deny",
    "no-obj-calls": "deny",
    "no-object-constructor": "deny",
    "no-plusplus": "deny",
    "no-proto": "deny",
    "no-prototype-builtins": "deny",
    "no-redeclare": "deny",
    "no-regex-spaces": "deny",
    "no-restricted-globals": "deny",
    "no-restricted-imports": "deny",
    "no-return-assign": "deny",
    "no-script-url": "deny",
    "no-self-assign": "deny",
    "no-self-compare": "deny",
    "no-setter-return": "deny",
    "no-shadow-restricted-names": "deny",
    "no-sparse-arrays": "deny",
    "no-template-curly-in-string": "deny",
    "no-ternary": "deny",
    "no-this-before-super": "deny",
    "no-throw-literal": "deny",
    "no-undef": "deny",
    "no-undefined": "deny",
    "no-unexpected-multiline": "deny",
    "no-unneeded-ternary": "deny",
    "no-unreachable": "deny",
    "no-unsafe-finally": "deny",
    "no-unsafe-negation": "deny",
    "no-unsafe-optional-chaining": "deny",
    "no-unused-expressions": "deny",
    "no-unused-labels": "deny",
    "no-unused-private-class-members": "deny",
    "no-unused-vars": "deny",
    "no-useless-backreference": "deny",
    "no-useless-call": "deny",
    "no-useless-catch": "deny",
    "no-useless-concat": "deny",
    "no-useless-constructor": "deny",
    "no-useless-escape": "deny",
    "no-useless-rename": "deny",
    "no-var": "deny",
    "no-void": "deny",
    "no-with": "deny",
    "operator-assignment": "deny",
    "prefer-exponentiation-operator": "deny",
    "prefer-numeric-literals": "deny",
    "prefer-object-has-own": "deny",
    "prefer-object-spread": "deny",
    "prefer-promise-reject-errors": "deny",
    "prefer-rest-params": "deny",
    "prefer-spread": "deny",
    "radix": "deny",
    "require-await": "deny",
    "require-yield": "deny",
    "sort-imports": "deny",
    "sort-keys": "deny",
    "sort-vars": "deny",
    "symbol-description": "deny",
    "unicode-bom": "deny",
    "use-isnan": "deny",
    "valid-typeof": "deny",
    "vars-on-top": "deny",
    "yoda": "deny",
    "import/consistent-type-specifier-style": "deny",
    "import/default": "deny",
    "import/export": "deny",
    "import/exports-last": "deny",
    "import/extensions": "deny",
    "import/first": "deny",
    "import/group-exports": "deny",
    "import/max-dependencies": "deny",
    "import/named": "deny",
    "import/namespace": "deny",
    "import/no-absolute-path": "deny",
    "import/no-amd": "deny",
    "import/no-anonymous-default-export": "deny",
    "import/no-commonjs": "deny",
    "import/no-cycle": "deny",
    "import/no-default-export": "deny",
    "import/no-duplicates": "deny",
    "import/no-dynamic-require": "deny",
    "import/no-empty-named-blocks": "deny",
    "import/no-mutable-exports": "deny",
    "import/no-named-as-default": "deny",
    "import/no-named-as-default-member": "deny",
    "import/no-named-default": "deny",
    "import/no-namespace": "deny",
    "import/no-self-import": "deny",
    "import/no-unassigned-import": "deny",
    "import/no-webpack-loader-syntax": "deny",
    "import/prefer-default-export": "deny",
    "import/unambiguous": "deny",
    "oxc/approx-constant": "deny",
    "oxc/bad-array-method-on-arguments": "deny",
    "oxc/bad-bitwise-operator": "deny",
    "oxc/bad-char-at-comparison": "deny",
    "oxc/bad-comparison-sequence": "deny",
    "oxc/bad-min-max-func": "deny",
    "oxc/bad-object-literal-comparison": "deny",
    "oxc/bad-replace-all-arg": "deny",
    "oxc/const-comparisons": "deny",
    "oxc/double-comparisons": "deny",
    "oxc/erasing-op": "deny",
    "oxc/misrefactored-assign-op": "deny",
    "oxc/missing-throw": "deny",
    "oxc/no-accumulating-spread": "deny",
    "oxc/no-async-await": "deny",
    "oxc/no-async-endpoint-handlers": "deny",
    "oxc/no-barrel-file": "deny",
    "oxc/no-const-enum": "deny",
    "oxc/no-map-spread": "deny",
    "oxc/no-optional-chaining": "deny",
    "oxc/no-rest-spread-properties": "deny",
    "oxc/number-arg-out-of-range": "deny",
    "oxc/only-used-in-recursion": "deny",
    "oxc/uninvoked-array-callback": "deny",
    "promise/avoid-new": "deny",
    "promise/catch-or-return": "deny",
    "promise/no-callback-in-promise": "deny",
    "promise/no-nesting": "deny",
    "promise/no-new-statics": "deny",
    "promise/no-promise-in-callback": "deny",
    "promise/no-return-in-finally": "deny",
    "promise/no-return-wrap": "deny",
    "promise/param-names": "deny",
    "promise/prefer-await-to-callbacks": "deny",
    "promise/prefer-await-to-then": "deny",
    "promise/prefer-catch": "deny",
    "promise/spec-only": "deny",
    "promise/valid-params": "deny",
    "typescript/adjacent-overload-signatures": "deny",
    "typescript/array-type": "deny",
    "typescript/ban-ts-comment": "deny",
    "typescript/ban-tslint-comment": "deny",
    "typescript/ban-types": "deny",
    "typescript/consistent-generic-constructors": "deny",
    "typescript/consistent-indexed-object-style": "deny",
    "typescript/consistent-type-definitions": "deny",
    "typescript/consistent-type-imports": "deny",
    "typescript/explicit-function-return-type": "deny",
    "typescript/no-confusing-non-null-assertion": "deny",
    "typescript/no-duplicate-enum-values": "deny",
    "typescript/no-dynamic-delete": "deny",
    "typescript/no-empty-interface": "deny",
    "typescript/no-empty-object-type": "deny",
    "typescript/no-explicit-any": "deny",
    "typescript/no-extra-non-null-assertion": "deny",
    "typescript/no-extraneous-class": "deny",
    "typescript/no-import-type-side-effects": "deny",
    "typescript/no-inferrable-types": "deny",
    "typescript/no-misused-new": "deny",
    "typescript/no-namespace": "deny",
    "typescript/no-non-null-asserted-nullish-coalescing": "deny",
    "typescript/no-non-null-asserted-optional-chain": "deny",
    "typescript/no-non-null-assertion": "deny",
    "typescript/no-require-imports": "deny",
    "typescript/no-this-alias": "deny",
    "typescript/no-unnecessary-parameter-property-assignment": "deny",
    "typescript/no-unnecessary-type-constraint": "deny",
    "typescript/no-unsafe-declaration-merging": "deny",
    "typescript/no-unsafe-function-type": "deny",
    "typescript/no-useless-empty-export": "deny",
    "typescript/no-var-requires": "deny",
    "typescript/no-wrapper-object-types": "deny",
    "typescript/prefer-as-const": "deny",
    "typescript/prefer-enum-initializers": "deny",
    "typescript/prefer-for-of": "deny",
    "typescript/prefer-function-type": "deny",
    "typescript/prefer-literal-enum-member": "deny",
    "typescript/prefer-namespace-keyword": "deny",
    "typescript/prefer-ts-expect-error": "deny",
    "typescript/triple-slash-reference": "deny",
    "unicorn/catch-error-name": "deny",
    "unicorn/consistent-assert": "deny",
    "unicorn/consistent-date-clone": "deny",
    "unicorn/consistent-empty-array-spread": "deny",
    "unicorn/consistent-existence-index-check": "deny",
    "unicorn/consistent-function-scoping": "deny",
    "unicorn/empty-brace-spaces": "deny",
    "unicorn/error-message": "deny",
    "unicorn/escape-case": "deny",
    "unicorn/explicit-length-check": "deny",
    "unicorn/filename-case": "deny",
    "unicorn/new-for-builtins": "deny",
    "unicorn/no-abusive-eslint-disable": "deny",
    "unicorn/no-accessor-recursion": "deny",
    "unicorn/no-anonymous-default-export": "deny",
    "unicorn/no-array-for-each": "deny",
    "unicorn/no-array-method-this-argument": "deny",
    "unicorn/no-array-reduce": "deny",
    "unicorn/no-await-expression-member": "deny",
    "unicorn/no-await-in-promise-methods": "deny",
    "unicorn/no-console-spaces": "deny",
    "unicorn/no-document-cookie": "deny",
    "unicorn/no-empty-file": "deny",
    "unicorn/no-hex-escape": "deny",
    "unicorn/no-instanceof-array": "deny",
    "unicorn/no-instanceof-builtins": "deny",
    "unicorn/no-invalid-fetch-options": "deny",
    "unicorn/no-invalid-remove-event-listener": "deny",
    "unicorn/no-length-as-slice-end": "deny",
    "unicorn/no-lonely-if": "deny",
    "unicorn/no-magic-array-flat-depth": "deny",
    "unicorn/no-negation-in-equality-check": "deny",
    "unicorn/no-nested-ternary": "deny",
    "unicorn/no-new-array": "deny",
    "unicorn/no-new-buffer": "deny",
    "unicorn/no-null": "deny",
    "unicorn/no-object-as-default-parameter": "deny",
    "unicorn/no-process-exit": "deny",
    "unicorn/no-single-promise-in-promise-methods": "deny",
    "unicorn/no-static-only-class": "deny",
    "unicorn/no-thenable": "deny",
    "unicorn/no-this-assignment": "deny",
    "unicorn/no-typeof-undefined": "deny",
    "unicorn/no-unnecessary-array-flat-depth": "deny",
    "unicorn/no-unnecessary-await": "deny",
    "unicorn/no-unnecessary-slice-end": "deny",
    "unicorn/no-unreadable-array-destructuring": "deny",
    "unicorn/no-unreadable-iife": "deny",
    "unicorn/no-useless-fallback-in-spread": "deny",
    "unicorn/no-useless-length-check": "deny",
    "unicorn/no-useless-promise-resolve-reject": "deny",
    "unicorn/no-useless-spread": "deny",
    "unicorn/no-useless-switch-case": "deny",
    "unicorn/no-useless-undefined": "deny",
    "unicorn/no-zero-fractions": "deny",
    "unicorn/number-literal-case": "deny",
    "unicorn/numeric-separators-style": "deny",
    "unicorn/prefer-add-event-listener": "deny",
    "unicorn/prefer-array-find": "deny",
    "unicorn/prefer-array-flat": "deny",
    "unicorn/prefer-array-flat-map": "deny",
    "unicorn/prefer-array-index-of": "deny",
    "unicorn/prefer-array-some": "deny",
    "unicorn/prefer-blob-reading-methods": "deny",
    "unicorn/prefer-code-point": "deny",
    "unicorn/prefer-date-now": "deny",
    "unicorn/prefer-dom-node-append": "deny",
    "unicorn/prefer-dom-node-dataset": "deny",
    "unicorn/prefer-dom-node-remove": "deny",
    "unicorn/prefer-dom-node-text-content": "deny",
    "unicorn/prefer-event-target": "deny",
    "unicorn/prefer-global-this": "deny",
    "unicorn/prefer-includes": "deny",
    "unicorn/prefer-logical-operator-over-ternary": "deny",
    "unicorn/prefer-math-min-max": "deny",
    "unicorn/prefer-math-trunc": "deny",
    "unicorn/prefer-modern-dom-apis": "deny",
    "unicorn/prefer-modern-math-apis": "deny",
    "unicorn/prefer-native-coercion-functions": "deny",
    "unicorn/prefer-negative-index": "deny",
    "unicorn/prefer-node-protocol": "deny",
    "unicorn/prefer-number-properties": "deny",
    "unicorn/prefer-object-from-entries": "deny",
    "unicorn/prefer-optional-catch-binding": "deny",
    "unicorn/prefer-prototype-methods": "deny",
    "unicorn/prefer-query-selector": "deny",
    "unicorn/prefer-reflect-apply": "deny",
    "unicorn/prefer-regexp-test": "deny",
    "unicorn/prefer-set-has": "deny",
    "unicorn/prefer-set-size": "deny",
    "unicorn/prefer-spread": "deny",
    "unicorn/prefer-string-raw": "deny",
    "unicorn/prefer-string-replace-all": "deny",
    "unicorn/prefer-string-slice": "deny",
    "unicorn/prefer-string-starts-ends-with": "deny",
    "unicorn/prefer-string-trim-start-end": "deny",
    "unicorn/prefer-structured-clone": "deny",
    "unicorn/prefer-type-error": "deny",
    "unicorn/require-array-join-separator": "deny",
    "unicorn/require-number-to-fixed-digits-argument": "deny",
    "unicorn/require-post-message-target-origin": "deny",
    "unicorn/switch-case-braces": "deny",
    "unicorn/text-encoding-identifier-case": "deny",
    "unicorn/throw-new-error": "deny"
  },
  "settings": {
    "jsx-a11y": {
      "polymorphicPropName": null,
      "components": {}
    },
    "next": {
      "rootDir": []
    },
    "react": {
      "formComponents": [],
      "linkComponents": []
    },
    "jsdoc": {
      "ignorePrivate": false,
      "ignoreInternal": false,
      "ignoreReplacesDocs": true,
      "overrideReplacesDocs": true,
      "augmentsExtendsReplacesDocs": false,
      "implementsReplacesDocs": false,
      "exemptDestructuredRootsFromChecks": false,
      "tagNamePreference": {}
    }
  },
  "env": {
    "builtin": true
  },
  "globals": {},
  "ignorePatterns": [
    "/node_modules",
    "/dist",
    "/*.{js,ts}"
  ]
}

As you can see, unicorn/switch-case-braces is set to "deny", which by default (according to the docs), should require braces.

But when I run oxlint, it reports issues on case statements that have braces as being unnessary, even though the default is to require them.

  × eslint-plugin-unicorn(switch-case-braces): Unnecessary braces in case clause.
    ╭─[src/scenes/basic.ts:65:16]
 64 │     
 65 │ ╭─▶       default: {
 66 │ │           console.error('Unsupported Websocket Payload', payload)
 67 │ ╰─▶       }
 68 │         }
    ╰────
  help: Remove Braces for case clause.

If I then add "unicorn/switch-case-braces": "deny" to my oxlintrc.json file, the print-config is enactly the same, but those warnings disappear.

So when enabled via categories, the default doesn't seem to be taken into account. But when added manually, then it is.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions