Skip to content

oxfmt: ! prefixed ignore path does not work #14684

@leaysgur

Description

@leaysgur

Given this file structure:

❯ tree
(cwd)
├── foo
│   ├── bar
│   │   ├── error.js
│   │   └── ok.js
│   └── ok.js
└── ok.js

This is expected.

❯ npx oxfmt@latest --check
Checking formatting...
foo/bar/ok.js (0ms)
foo/ok.js (0ms)
ok.js (0ms)

  × Expected `}` but found `EOF`
   ╭─[foo/bar/error.js:2:1]
 1 │ class {
   ╰────

Error occurred when checking code style in the above files.

But these are not.

❯ npx oxfmt@latest --check . '!foo/bar/error.js'
Checking formatting...
foo/bar/ok.js (0ms)
foo/ok.js (0ms)
ok.js (0ms)

  × Expected `}` but found `EOF`
   ╭─[foo/bar/error.js:2:1]
 1 │ class {
   ╰────

Error occurred when checking code style in the above files.

❯ npx oxfmt@latest --check . '!foo/bar'
Checking formatting...
foo/bar/ok.js (0ms)
foo/ok.js (0ms)
ok.js (0ms)

  × Expected `}` but found `EOF`
   ╭─[foo/bar/error.js:2:1]
 1 │ class {
   ╰────

Error occurred when checking code style in the above files.

One thing I noticed:

❯ npx oxfmt@latest --check . '!foo'
Checking formatting...
ok.js (0ms)

Format issues found in above 1 files. Run without `--check` to fix.
Finished in 1ms on 1 files using 8 threads.

!ignore may not work for nested directory.

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions