Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformer: improve the implementation of eliminating type-only exports #3827

Closed
Dunqing opened this issue Jun 22, 2024 · 4 comments · Fixed by #4321
Closed

transformer: improve the implementation of eliminating type-only exports #3827

Dunqing opened this issue Jun 22, 2024 · 4 comments · Fixed by #4321
Assignees
Labels
A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance

Comments

@Dunqing
Copy link
Member

Dunqing commented Jun 22, 2024

#3820 was added IdentifierReference to ExportSpecifier. This means we no longer need to collect type-only import binding names.

if is_type || s.import_kind.is_type() {
self.type_identifier_names.insert(s.local.name.clone());
return false;
}

We just need to check if the import binding has a type reference.

But, unfortunately, we're currently stuck due to issue #3826. Once it's fixed, I'll be able to start working on this.

@Dunqing Dunqing added C-performance Category - Solution not expected to change functional behavior, only performance A-transformer Area - Transformer / Transpiler labels Jun 22, 2024
@Dunqing Dunqing self-assigned this Jun 22, 2024
@Dunqing
Copy link
Member Author

Dunqing commented Jun 24, 2024

@overlookmotel
Copy link
Contributor

I think we need to resolve the questions in #3799 before tackling this.

@Dunqing
Copy link
Member Author

Dunqing commented Jun 24, 2024

I think we need to resolve the questions in #3799 before tackling this.

Yes

@overlookmotel
Copy link
Contributor

According to comment there, #3827 closes this. @Dunqing please re-open if that's not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants