False positive for no-unused-vars

[florianwittmann]

In the following case text in the first line is found by no-unused-vars, but not found by the original eslint rule:

   const { text, ...dbEntry } = entry;
    return doSomething({
      ...dbEntry,
      someOtherProp
    });

Here we want to get entry without text and this seems to be one legit way to do this, hence text is not unused. This was tested with version 0.7.1.

[camc314]

hmm this reports an error on text for me? maybe a diff between the eslint vs typescript eslint rule?

the quick solve for this is to do something like: const { text: _text, ...dbEntry } = entry although it requires changing code

[DonIsaac]

I think there's a bug in the code handling ignoreRestSiblings.

Just to confirm, you did set this option to true, correct?

[florianwittmann]

Yes, it is active, with the following additional configuration:

      "no-unused-vars": [
        "warn",
        {
          "args": "none",
          "caughtErrors": "none",
          "ignoreRestSiblings": true,
          "vars": "all"
        }
      ],

[DonIsaac]

@florianwittmann can you please show me the command you're using to run oxlint?

[DonIsaac]

I am unable to reproduce this issue, please provide any additional setup/command arguments/etc you used so I can debug it.

[florianwittmann]

Found the problem, it was referencing the wrong config file the hole time 🤦 Sorry, everything seems to work as intended, when configured correctly.