Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference::flag method should return ReferenceFlag, not &ReferenceFlag #4992

Closed
overlookmotel opened this issue Aug 19, 2024 · 1 comment · Fixed by #5019
Closed

Reference::flag method should return ReferenceFlag, not &ReferenceFlag #4992

overlookmotel opened this issue Aug 19, 2024 · 1 comment · Fixed by #5019
Labels
A-semantic Area - Semantic

Comments

@overlookmotel
Copy link
Contributor

ReferenceFlag is Copy. Reference::flag method should return ReferenceFlag (1 byte), not &ReferenceFlag (8 bytes).

See also #4991 - I also propose renaming this method.
@overlookmotel overlookmotel added the A-semantic Area - Semantic label Aug 19, 2024
@overlookmotel overlookmotel mentioned this issue Aug 20, 2024
Merged
@overlookmotel
Copy link
Contributor Author

Fixed in #5019.

overlookmotel added a commit that referenced this issue Aug 20, 2024
@overlookmotel
refactor(semantic)!: Reference::flag method return ReferenceFlag (#…
c30e2e9 
…5019)

Closes #4992.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-semantic Area - Semantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(semantic)!: Reference::flag method return ReferenceFlag oxc-project/oxc
1 participant
@overlookmotel