Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isolated declarations: performance regression due to cloning too much #6074

Closed
Boshen opened this issue Sep 26, 2024 · 1 comment · Fixed by #6078
Closed

isolated declarations: performance regression due to cloning too much #6074

Boshen opened this issue Sep 26, 2024 · 1 comment · Fixed by #6078
Assignees
@Dunqing
Labels
A-isolated-declarations Isolated Declarations C-bug Category - Bug

Comments

@Boshen
Copy link
Member

Boshen commented Sep 26, 2024

oxc/crates/oxc_isolated_declarations/src/lib.rs

Line 154 in c2616f7

Some(stmt.clone_in(self.ast.allocator))

oxc/crates/oxc_isolated_declarations/src/lib.rs

Line 192 in c2616f7

Some(stmt.clone_in(self.ast.allocator))

@Boshen Boshen added the C-bug Category - Bug label Sep 26, 2024
@Boshen Boshen added the A-isolated-declarations Isolated Declarations label Sep 26, 2024
@Dunqing Dunqing mentioned this issue Sep 26, 2024
Merged
Boshen pushed a commit that referenced this issue Sep 26, 2024
@Dunqing
perf(isolated-declarations): should clone transformed AST rather than…
6b7d3ed 
… original AST (#6078)

close: #6074
Performance regression introduced by #5909. After this PR we back to the fold pattern again
@overlookmotel
Copy link
Collaborator

Fixed in #6078.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dunqing Dunqing

Labels
A-isolated-declarations Isolated Declarations C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(isolated-declarations): should clone transformed AST rather than original AST oxc-project/oxc
3 participants
@overlookmotel @Boshen @Dunqing