Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linter: no-control-regex regression #6136

Closed
Boshen opened this issue Sep 28, 2024 · 0 comments · Fixed by #6140
Closed

linter: no-control-regex regression #6136

Boshen opened this issue Sep 28, 2024 · 0 comments · Fixed by #6140
Assignees
@camchenry
Labels
C-bug Category - Bug

Comments

@Boshen
Copy link
Member

Boshen commented Sep 28, 2024

See https://github.com/oxc-project/oxlint-ecosystem-ci/actions/runs/11082800221/job/30796312823
@Boshen Boshen added the C-bug Category - Bug label Sep 28, 2024
@camchenry camchenry mentioned this issue Sep 28, 2024
Merged
Boshen pushed a commit that referenced this issue Sep 28, 2024
@camchenry
fix(linter): allow whitespace control characters in no-control-regex (
ffd75f7 
#6140)

- fixes #6136

The original eslint rule checks if chars start with `\u` or `\x`, but our character spans are currently busted and only report 1 char for chars like `\u{0a}`. I've made whitespace an exception to the rule, so we don't report `\x0a` currently, which is fine for now I think
Boshen pushed a commit that referenced this issue Sep 28, 2024
@camchenry
fix(linter): allow whitespace control characters in no-control-regex (
be0030c 
#6140)

- fixes #6136

The original eslint rule checks if chars start with `\u` or `\x`, but our character spans are currently busted and only report 1 char for chars like `\u{0a}`. I've made whitespace an exception to the rule, so we don't report `\x0a` currently, which is fine for now I think
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camchenry camchenry

Labels
C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(linter): allow whitespace control characters in no-control-regex oxc-project/oxc
2 participants
@Boshen @camchenry