Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: support disable jsx transformer at napi #7958

Closed
underfin opened this issue Dec 17, 2024 · 0 comments · Fixed by #7965
Closed

[Feature Request]: support disable jsx transformer at napi #7958

underfin opened this issue Dec 17, 2024 · 0 comments · Fixed by #7965
Assignees
@Boshen
Labels
A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Comments

@underfin
Copy link
Contributor

underfin commented Dec 17, 2024 •
edited
Loading

The rolldown-vite using it to compat tsconfig.json jsx: 'preserve' behavior, the esbuild respect it, ref https://github.com/rolldown/vite/blob/rolldown-v6/packages/vite/src/node/plugins/oxc.ts#L111

The transformer has jsx_plugin option to do it, add it to napi look like could be work.
@underfin underfin added the C-enhancement Category - New feature or request label Dec 17, 2024
@Dunqing Dunqing added good first issue Experience Level - Good for newcomers A-transformer Area - Transformer / Transpiler labels Dec 17, 2024
@Dunqing Dunqing self-assigned this Dec 17, 2024
@Boshen Boshen assigned Boshen and unassigned Dunqing Dec 17, 2024
@Boshen Boshen removed the good first issue Experience Level - Good for newcomers label Dec 17, 2024
Boshen added a commit that referenced this issue Dec 17, 2024
@Boshen
feat(napi/transform): add jsx: 'preserve' option
6ccc4e2 
closes #7958
@Boshen Boshen mentioned this issue Dec 17, 2024
Merged
Boshen added a commit that referenced this issue Dec 17, 2024
@Boshen
feat(napi/transform): add jsx: 'preserve' option (#7965)
c16a851 
closes #7958
@Boshen Boshen closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(napi/transform): add jsx: 'preserve' option oxc-project/oxc
3 participants
@Boshen @underfin @Dunqing