a small question about cow-utils

[heygsc]

related: #8496

Sorry, I should have asked about it in the previous issue mentioned above. I didn't pay attention and it was already closed.

A small question, I'm really curious. Since cow_to_lowercase and some methods based on the benchmark will reduce performance, is it necessary to revert some methods in the disallowed-methods restriction in clippy?

[Boshen]

Take a look at the call sites, most of them can be replaced with cow_to_ascii_uppercase as they don't need to deal with unicode casing.

Most call sites are comparing very short strings, which is still fast compared to always heap allocating in String::to_upper_case.

[Boshen]

most of them can be replaced with cow_to_ascii_uppercase

We should refactor some of the call sites.

[Boshen]

This is a nice catch, thank you for bringing this up.

[heygsc]

This is a nice catch, thank you for bringing this up.

Hahaha, thank you for your explanation too.