-
-
Notifications
You must be signed in to change notification settings - Fork 735
feat(language_server): use linter runtime #10268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(language_server): use linter runtime #10268
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10268 will not alter performanceComparing Summary
|
89c16bd to
79ef26f
Compare
|
Just commenting here to say I think this is generally the right direction: we should use the same runtime as |
79ef26f to
ee3a35a
Compare
876b6ea to
8bb564b
Compare
ee3a35a to
ece9032
Compare
d9b0ef8 to
4077f39
Compare
29d4877 to
c12bf89
Compare
abbac7d to
5e435f1
Compare
c12bf89 to
b26c940
Compare
5e435f1 to
942fb45
Compare
I thought about that. My preferred way is to handle it inside the runtime. |
942fb45 to
d48e886
Compare
b26c940 to
6654d6c
Compare
e71ae59 to
39433d9
Compare
c621b92 to
58ab118
Compare
58ab118 to
b852314
Compare
b852314 to
861d63a
Compare
bc84417 to
664342b
Compare
861d63a to
1fef6d1
Compare
Boshen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test and release the lsp changes before merging this.
1fef6d1 to
b3b3054
Compare
Merge activity
|
closes #7118 Added tests for: - (language_server & VSCode) nested configuration - (language_server & VSCode) nested configuration extends - (language_server) without nested configuration The implementation requires at the moment a feature flag for `oxc_linter`. I added documentation in `runtime.rs` to let others know why this is needed. Maybe someone can refactor it to avoid the flag. My first idea is a Trait for file system, but you guys know what to do <3 
b3b3054 to
bb8a078
Compare

closes #7118
Added tests for:
The implementation requires at the moment a feature flag for
oxc_linter. I added documentation inruntime.rsto let others know why this is needed. Maybe someone can refactor it to avoid the flag. My first idea is a Trait for file system, but you guys know what to do <3