Skip to content

fix(codegen): escape "</script" #10340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(codegen): escape "</script" #10340

wants to merge 1 commit into from

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Apr 9, 2025 •
edited
Loading

Partial fix for #10334. Only handles escaping </script in strings. Does not handle template literals, regexs, or comments.

@github-actions github-actions bot added the A-codegen Area - Code Generation label Apr 9, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Apr 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Apr 9, 2025
@overlookmotel overlookmotel mentioned this pull request Apr 9, 2025
Closed
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 9, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10340 will not alter performance

Comparing 04-09-fix_codegen_escape__script_ (a36061e) with main (0370363)

Summary

✅ 36 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 04-09-fix_codegen_escape__script_ branch from b52ac61 to a36061e Compare April 9, 2025 18:11
@xu-cheng xu-cheng mentioned this pull request Apr 21, 2025
Closed
@xu-cheng xu-cheng mentioned this pull request Jun 17, 2025
Merged
overlookmotel added a commit that referenced this pull request Jul 2, 2025
@xu-cheng @overlookmotel
fix(codegen): escape </script (#11782)
22799c3 
Fixes #10334.

Replace #10340 to cover the escape for both template literals and comments. We don’t need to handle regex, which is already covered by existing codegen.

Please let me know anything needed to merge this PR. Thanks.

---------

Co-authored-by: overlookmotel <theoverlookmotel@gmail.com>
@overlookmotel
Copy link
Member Author

overlookmotel commented Jul 2, 2025

Superceded by #11782.

@overlookmotel overlookmotel deleted the 04-09-fix_codegen_escape__script_ branch July 2, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

A-codegen Area - Code Generation C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel