-
-
Notifications
You must be signed in to change notification settings - Fork 736
fix(estree): Align TSMappedType fields
#10392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Instrumentation Performance ReportMerging #10392 will not alter performanceComparing Summary
|
|
This PR is marked as draft, so I've not reviewed yet. Please let me know when it's ready for review. |
|
Thank you for your concern! 🙏🏻 |
|
@overlookmotel Thank you for your patience each time~, please take a look? |
overlookmotel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! All my comments are just nits.
No no no! Thank you for doggedly pursuing this effort. Really appreciate it. |
|
I realized we're in completely different time zones, and I didn't want for this PR to end up with merge conflicts by the time you'd applied changes, and then waited for me to wake up in the morning and merge it. As my change suggestions were all minor nits, I've taken the liberty of making the changes myself, and will merge this as soon as CI passes. Details in the comments above. I hope you don't mind. If anything you don't like in the changes I've made, please feel free to say so and revert them! |
|
Now over 80% passing 🎉 |
Ah~, indeed! I live in JST(GMT+9) and it is time to start working now. 🫖
I don't mind at all and would rather thank you for doing it instead.
🥳 |
Part of #9705
In this PR, I've tried to align
TSMappedTypewith TS-ESLint.And also fixed serializer for
optionalandreadonlytypes.They are defined as
boolean | '+' | '-' | undefined, but we usetrue | '+' | '-' | null.