Skip to content

fix(ast)!: change Class::implements to Vec<TSClassImplements> #10430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

fix(ast)!: change Class::implements to Vec<TSClassImplements> #10430

merged 1 commit into from
Apr 16, 2025

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Apr 16, 2025

fixes #10421

@github-actions github-actions bot added A-parser Area - Parser A-semantic Area - Semantic A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation C-bug Category - Bug labels Apr 16, 2025
@Boshen Graphite App
Copy link
Member Author

Boshen commented Apr 16, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 16, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 04-16-fix_ast_change_class_implements_to_vec_tsclassimplements_ branch from 2a559af to 771d50f Compare April 16, 2025 02:58
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 16, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10430 will not alter performance

Comparing 04-16-fix_ast_change_class_implements_to_vec_tsclassimplements_ (771d50f) with main (3d7bcac)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot merged commit 771d50f into main Apr 16, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 04-16-fix_ast_change_class_implements_to_vec_tsclassimplements_ branch April 16, 2025 03:04
@oxc-bot oxc-bot mentioned this pull request Apr 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

No one assigned

Labels

A-ast Area - AST A-codegen Area - Code Generation A-parser Area - Parser A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(parser): ambiguity for Class::implements

2 participants

@Boshen