Skip to content

refactor(ast)!: remove ArrayAssignmentTarget::new_with_elements and ObjectAssignmentTarget::new_with_properties #10440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

refactor(ast)!: remove ArrayAssignmentTarget::new_with_elements and ObjectAssignmentTarget::new_with_properties #10440

merged 1 commit into from
Apr 16, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Apr 16, 2025 •
edited
Loading

Remove these 2 methods because:

  1. All AST node creation is meant to go through AstBuilder.
  2. Neither method is used.

@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Apr 16, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Apr 16, 2025
Merged
@overlookmotel overlookmotel marked this pull request as ready for review April 16, 2025 13:28
@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 16, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 16, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10440 will not alter performance

Comparing 04-16-refactor_ast_remove_arrayassignmenttarget_new_with_elements_and_objectassignmenttarget_new_with_properties_ (09f4c30) with main (8db9dc5)

Summary

✅ 36 untouched benchmarks

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 16, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Apr 16, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel
refactor(ast)!: remove ArrayAssignmentTarget::new_with_elements and…
09f4c30 
… `ObjectAssignmentTarget::new_with_properties` (#10440)

Remove these 2 methods because:

1. All AST node creation is meant to go through `AstBuilder`.
2. Neither method is used.
@graphite-app graphite-app bot force-pushed the 04-16-refactor_ast_remove_arrayassignmenttarget_new_with_elements_and_objectassignmenttarget_new_with_properties_ branch from a0a23d6 to 09f4c30 Compare April 16, 2025 13:57
@graphite-app graphite-app bot merged commit 09f4c30 into main Apr 16, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-16-refactor_ast_remove_arrayassignmenttarget_new_with_elements_and_objectassignmenttarget_new_with_properties_ branch April 16, 2025 14:04
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 16, 2025
@oxc-bot oxc-bot mentioned this pull request Apr 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dunqing Dunqing Dunqing approved these changes

Assignees

No one assigned

Labels

A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@overlookmotel @Dunqing