Skip to content

feat(transformer/typescript): support removeClassFieldsWithoutInitializer option #10576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Apr 25, 2025
Merged

feat(transformer/typescript): support removeClassFieldsWithoutInitializer option #10576

graphite-app merged 1 commit into from
Apr 25, 2025

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 24, 2025 •
edited
Loading

We've discussed adding removeClassFieldsWithoutInitializer option to support removing class fields without an initializer in #10491 (comment). This is used to align theTypeScript's useDefineForClassFields: false option.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Apr 24, 2025
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Apr 24, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 24, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10576 will not alter performance

Comparing 04-24-feat_transformer_typescript_support_removeclassfieldswithoutinitializer_option (6bff64e) with main (39adefe)

Summary

✅ 28 untouched benchmarks
⁉️ 8 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ formatter[antd.js] 708.3 ms N/A N/A
⁉️ formatter[react.development.js] 8 ms N/A N/A
⁉️ formatter[typescript.js] 1.1 s N/A N/A
⁉️ transformer[RadixUIAdoptionSection.jsx] 135.6 µs N/A N/A
⁉️ transformer[antd.js] 49.8 ms N/A N/A
⁉️ transformer[cal.com.tsx] 32.9 ms N/A N/A
⁉️ transformer[checker.ts] 22 ms N/A N/A
⁉️ transformer[pdf.mjs] 10.2 ms N/A N/A

@Dunqing Dunqing force-pushed the 04-24-feat_transformer_typescript_support_removeclassfieldswithoutinitializer_option branch from 32a213f to 23c0ece Compare April 24, 2025 07:37
@Dunqing Dunqing mentioned this pull request Apr 24, 2025
Merged
@Dunqing Dunqing requested a review from sapphi-red April 24, 2025 07:38
@Dunqing
Copy link
Member Author

Dunqing commented Apr 24, 2025

@sapphi-red could you review this?

@Dunqing Dunqing marked this pull request as ready for review April 24, 2025 07:48
@Dunqing Dunqing requested a review from overlookmotel as a code owner April 24, 2025 07:48
@Dunqing Dunqing mentioned this pull request Apr 24, 2025
Merged
sapphi-red
sapphi-red reviewed Apr 24, 2025
View reviewed changes
This was referenced Apr 24, 2025
Merged
Merged
@Dunqing Dunqing force-pushed the 04-24-feat_transformer_typescript_support_removeclassfieldswithoutinitializer_option branch from 23c0ece to 097d8d4 Compare April 24, 2025 09:56
@Dunqing Dunqing requested a review from sapphi-red April 24, 2025 09:56
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 25, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 25, 2025 •
edited
Loading

Merge activity

@Dunqing
feat(transformer/typescript): support `removeClassFieldsWithoutInitia…
6bff64e 
…lizer` option (#10576)

* close #9192
* close #10491

We've discussed adding `removeClassFieldsWithoutInitializer` option to support removing class fields without an initializer in #10491 (comment). This is used to align the`TypeScript`'s `useDefineForClassFields: false` option.
@graphite-app graphite-app bot force-pushed the 04-24-feat_transformer_typescript_support_removeclassfieldswithoutinitializer_option branch from 097d8d4 to 6bff64e Compare April 25, 2025 01:30
@graphite-app graphite-app bot merged commit 6bff64e into main Apr 25, 2025
27 of 29 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 25, 2025
@graphite-app graphite-app bot deleted the 04-24-feat_transformer_typescript_support_removeclassfieldswithoutinitializer_option branch April 25, 2025 01:36
@Boshen Boshen mentioned this pull request Apr 27, 2025
Closed
@oxc-bot oxc-bot mentioned this pull request Apr 27, 2025
Merged
@sapphi-red sapphi-red mentioned this pull request May 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees

No one assigned

Labels

A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

assumptions.setPublicClassFields doesn't fully simulate tsconfig useDefineForClassFields

3 participants

@Dunqing @sapphi-red