feat(ast, semantic): implement GetAddress for AstKind and AstNode
#11758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-semantic
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11758 will not alter performanceComparing Summary
|
camc314
approved these changes
Jun 16, 2025
overlookmotel
force-pushed
the
06-12-feat_ast_semantic_implement_getaddress_for_astkind_and_astnode_
branch
from
c944471 to
05cfad6
Compare
Member
Author
Merge activity
|
…e` (#11758) Implement `GetAddress` on `AstKind` and `AstNode`. This should make it a bit easier to migrate away from comparing spans to find out if 2 AST nodes are the same. This was unblocked by #11684 (thank you @ulrichstark).
graphite-app
bot
force-pushed
the
06-12-feat_ast_semantic_implement_getaddress_for_astkind_and_astnode_
branch
from
05cfad6 to
371473c
Compare
graphite-app
bot
deleted the
06-12-feat_ast_semantic_implement_getaddress_for_astkind_and_astnode_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
GetAddressonAstKindandAstNode. This should make it a bit easier to migrate away from comparing spans to find out if 2 AST nodes are the same.This was unblocked by #11684 (thank you @ulrichstark).