Skip to content

feat(traverse)!: introduce TraverseCtx<'a, State> #11770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

feat(traverse)!: introduce TraverseCtx<'a, State> #11770

merged 1 commit into from
Jun 18, 2025

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jun 17, 2025 •
edited
Loading

part of #11742

@github-actions github-actions bot added A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Jun 17, 2025
@Boshen Graphite App
Copy link
Member Author

Boshen commented Jun 17, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen changed the title feat(traverse): introduce TraverseCtx<'a, State> feat(traverse)!: introduce TraverseCtx<'a, State> Jun 17, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 17, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11770 will improve performances by 3.9%

Comparing 06-17-feat_traverse_introduce_traversectx_a_state_ (8ef1be2) with main (3de6b99)

Summary

⚡ 2 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ transformer[binder.ts] 1.5 ms 1.4 ms +3.7%
⚡ transformer[react.development.js] 637.3 µs 613.4 µs +3.9%

Dunqing
Dunqing previously requested changes Jun 17, 2025
View reviewed changes
Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I am curious where the performance improvement comes from.

@Boshen Boshen force-pushed the 06-17-feat_traverse_introduce_traversectx_a_state_ branch from 5ba433b to b77ef8e Compare June 17, 2025 09:52
@Boshen Boshen mentioned this pull request Jun 17, 2025
Merged
@Boshen Boshen force-pushed the 06-17-feat_traverse_introduce_traversectx_a_state_ branch 2 times, most recently from ad85cc4 to e74c20c Compare June 18, 2025 05:58
@Boshen Boshen mentioned this pull request Jun 18, 2025
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jun 18, 2025
@Boshen Boshen added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Jun 18, 2025
@Boshen Graphite App
Copy link
Member Author

Boshen commented Jun 18, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 06-17-feat_traverse_introduce_traversectx_a_state_ branch from e74c20c to 8ef1be2 Compare June 18, 2025 06:42
@graphite-app graphite-app bot merged commit 8ef1be2 into main Jun 18, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 18, 2025
@graphite-app graphite-app bot deleted the 06-17-feat_traverse_introduce_traversectx_a_state_ branch June 18, 2025 06:48
@oxc-bot oxc-bot mentioned this pull request Jun 23, 2025
Merged
Copilot AI mentioned this pull request Aug 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dunqing Dunqing Dunqing left review comments

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees

No one assigned

Labels

A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Boshen @Dunqing