refactor(napi/parser): lazy visitor: pre-calculate count of node types #11861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
Member
Author
Merge activity
|
camc314
reviewed
Jun 23, 2025
Comment on lines
+191
to
+193
| NODE_TYPE_IDS_MAP, | ||
| NODE_TYPES_COUNT: 178, | ||
| LEAF_NODE_TYPES_COUNT: 38, |
Contributor
There was a problem hiding this comment.
random thought, it could be cool if the minifier calculate these at compile time
Member
Author
There was a problem hiding this comment.
How do you mean? Does the minifier create Vec's with a number of elements equal to the number of node types / AstKinds?
overlookmotel
deleted the
06-21-refactor_napi_parser_lazy_visitor_pre-calculate_count_of_node_types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. Pre-calculate number of node types in codegen. This prepares the way for replacing the
Mapwith a plain JS object.