Skip to content

refactor(linter/no-named-as-default-members): remove needless lambda #11896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

refactor(linter/no-named-as-default-members): remove needless lambda #11896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions crates/oxc_linter/src/rules/import/no_named_as_default_member.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,30 +121,30 @@ impl Rule for NoNamedAsDefaultMember {
})
};

let process_member_expr = |member_expr: &MemberExpression| {
let Expression::Identifier(ident) = member_expr.object() else {
return;
};
let Some(prop_str) = member_expr.static_property_name() else {
return;
};
if let Some(module_name) = get_external_module_name_if_has_entry(ident, prop_str) {
ctx.diagnostic(no_named_as_default_member_dignostic(
match member_expr {
MemberExpression::ComputedMemberExpression(it) => it.span,
MemberExpression::StaticMemberExpression(it) => it.span,
MemberExpression::PrivateFieldExpression(it) => it.span,
},
&ident.name,
prop_str,
module_name.name(),
));
}
};

for item in ctx.nodes() {
match item.kind() {
AstKind::MemberExpression(member_expr) => process_member_expr(member_expr),
AstKind::MemberExpression(member_expr) => {
let Expression::Identifier(ident) = member_expr.object() else {
return;
};
let Some(prop_str) = member_expr.static_property_name() else {
return;
};
if let Some(module_name) =
get_external_module_name_if_has_entry(ident, prop_str)
{
ctx.diagnostic(no_named_as_default_member_dignostic(
match member_expr {
MemberExpression::ComputedMemberExpression(it) => it.span,
MemberExpression::StaticMemberExpression(it) => it.span,
MemberExpression::PrivateFieldExpression(it) => it.span,
},
&ident.name,
prop_str,
module_name.name(),
));
}
}
AstKind::VariableDeclarator(decl) => {
let Some(Expression::Identifier(ident)) = &decl.init else {
continue;
Expand Down
Loading