Skip to content

Conversation

@zettca
Copy link
Contributor

@zettca zettca commented Jun 26, 2025

prefer-string-replace-all has an incorrect "incorrect" example 😄
(copy-pasted from no-array-reduce)

@zettca zettca requested a review from camc314 as a code owner June 26, 2025 14:39
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 26, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the A-linter Area - Linter label Jun 26, 2025
@zettca zettca changed the title docs: fix prefer-string-replace-all incorrect example docs(lint): fix prefer-string-replace-all incorrect example Jun 26, 2025
@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label Jun 26, 2025
@zettca zettca changed the title docs(lint): fix prefer-string-replace-all incorrect example docs(lint): fix prefer-string-replace-all example Jun 26, 2025
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@camc314 camc314 changed the title docs(lint): fix prefer-string-replace-all example docs(linter): fix prefer-string-replace-all example Jun 26, 2025
@camc314 camc314 merged commit 0d3e8e7 into oxc-project:main Jun 26, 2025
24 checks passed
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 26, 2025

CodSpeed Instrumentation Performance Report

Merging #11921 will degrade performances by 13.09%

Comparing zettca:fix/docs (0477ce6) with main (06781ab)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.1 ms 3.5 ms -13.09%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants