Skip to content

fix(linter/prefer-dom-node-remove): panic when callee is ts non null expression #11949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025
Merged

fix(linter/prefer-dom-node-remove): panic when callee is ts non null expression #11949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/ast_util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ pub fn is_new_expression<'a>(
pub fn call_expr_method_callee_info<'a>(
call_expr: &'a CallExpression<'a>,
) -> Option<(Span, &'a str)> {
let member_expr = call_expr.callee.without_parentheses().as_member_expression()?;
let member_expr = call_expr.callee.get_inner_expression().as_member_expression()?;
member_expr.static_property_info()
}

Expand Down
1 change: 1 addition & 0 deletions crates/oxc_linter/src/rules/unicorn/prefer_dom_node_remove.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ fn test() {
r"a.b?.c.parentNode.removeChild(foo)",
r"a[b?.c].parentNode.removeChild(foo)",
r"a?.b.parentNode.removeChild(a.b)",
r"a.removeChild!(k)",
];

Tester::new(PreferDomNodeRemove::NAME, PreferDomNodeRemove::PLUGIN, pass, fail)
Expand Down
7 changes: 7 additions & 0 deletions crates/oxc_linter/src/snapshots/unicorn_prefer_dom_node_remove.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,3 +294,10 @@ source: crates/oxc_linter/src/tester.rs
· ───────────
╰────
help: Replace `parentNode.removeChild(childNode)` with `childNode{dotOrQuestionDot}remove()`.

⚠ eslint-plugin-unicorn(prefer-dom-node-remove): Prefer `childNode.remove()` over `parentNode.removeChild(childNode)`.
╭─[prefer_dom_node_remove.tsx:1:3]
1 │ a.removeChild!(k)
· ───────────
╰────
help: Replace `parentNode.removeChild(childNode)` with `childNode{dotOrQuestionDot}remove()`.
Loading