Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jun 29, 2025

parseWithoutReturn doesn't exist anywhere, so attempting to assign it to modules.exports does nothing:

Logging the value of import * as k from 'oxc-parser'

node example.mjs test.ts
[Module: null prototype] {
  ExportExportNameKind: { Name: 'Name', Default: 'Default', None: 'None' },
  ExportImportNameKind: {
    Name: 'Name',
    All: 'All',
    AllButDefault: 'AllButDefault',
    None: 'None'
  },
  ExportLocalNameKind: { Name: 'Name', Default: 'Default', None: 'None' },
  ImportNameKind: {
    Name: 'Name',
    NamespaceObject: 'NamespaceObject',
    Default: 'Default'
  },
  ParseResult: [Function: ParseResult],
  Severity: { Error: 'Error', Warning: 'Warning', Advice: 'Advice' },
  default: {
    ParseResult: [Function: ParseResult],
    ExportExportNameKind: { Name: 'Name', Default: 'Default', None: 'None' },
    ExportImportNameKind: {
      Name: 'Name',
      All: 'All',
      AllButDefault: 'AllButDefault',
      None: 'None'
    },
    ExportLocalNameKind: { Name: 'Name', Default: 'Default', None: 'None' },
    ImportNameKind: {
      Name: 'Name',
      NamespaceObject: 'NamespaceObject',
      Default: 'Default'
    },
    parseWithoutReturn: undefined,
    Severity: { Error: 'Error', Warning: 'Warning', Advice: 'Advice' },
    parseSync: [Function: parseSync],
    parseAsync: [AsyncFunction: parseAsync],
    experimentalGetLazyVisitor: [Function: experimentalGetLazyVisitor],
    rawTransferSupported: [Function: rawTransferSupported]
  },
  experimentalGetLazyVisitor: [Function: experimentalGetLazyVisitor],
  parseAsync: [AsyncFunction: parseAsync],
  parseSync: [Function: parseSync],
  parseWithoutReturn: undefined,
  rawTransferSupported: [Function: rawTransferSupported]
}

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jun 29, 2025
Copy link
Contributor Author

camc314 commented Jun 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review June 29, 2025 15:09
@camc314 camc314 requested a review from overlookmotel June 29, 2025 15:09
@Boshen Boshen merged commit f1c18d8 into main Jun 30, 2025
17 checks passed
@Boshen Boshen deleted the c/06-29-chore_napi_parser_remove_undefined_module.exports_ branch June 30, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants