fix(parser): allow extends this.B syntax
#12038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12038 will not alter performanceComparing Summary
|
Member
Merge activity
|
Syntactically, this is valid. It is only an error when you get to type checking. The error code itself can be handled as part of #11582, but this fixes an issue where we emitted an error for a case that should definitely be valid, as pointed out in the file itself.
graphite-app
bot
force-pushed
the
07-02-fix_parser_allow_extends_this.b_syntax
branch
from
52bd590 to
6d865af
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
Follow-on after #12038. Call `Expression::without_parentheses` once, instead of twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntactically, this is valid. It is only an error when you get to type checking. The error code itself can be handled as part of #11582, but this fixes an issue where we emitted an error for a case that should definitely be valid, as pointed out in the file itself.