-
-
Notifications
You must be signed in to change notification settings - Fork 726
fix(transformer/legacy-decorator): decorated fields with the declare modifier are not transformed
#12212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Boshen
merged 1 commit into
main
from
07-11-fix_transformer_legacy-decorator_decorated_fields_with_the_declare_modifier_are_not_transformed
Jul 12, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
CodSpeed Instrumentation Performance ReportMerging #12212 will not alter performanceComparing Summary
|
d6300d7 to
0d17c57
Compare
0d17c57 to
470a724
Compare
470a724 to
1e4dd7c
Compare
This was referenced Jul 11, 2025
385516d to
1974408
Compare
20854b0 to
7dc1a91
Compare
Member
overlookmotel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this transform, so have not reviewed. Please feel free to merge if you're happy with it.
caa2e11 to
2690913
Compare
1974408 to
22b37b3
Compare
2690913 to
5ad62cd
Compare
22b37b3 to
3510778
Compare
3510778 to
c76e3f0
Compare
Member
Merge activity
|
…modifier are not transformed
c76e3f0 to
ef69c5c
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 21, 2025
…2417) * close rolldown/rolldown#5326 Regression introduced by #12212. The transform execution shift causes the bug because the `class-properties` plugin always assumes that all fields accessed can be transformed. However, the prior change breaks the assumption. This PR reverts some changes to remove the ts-only field early, which respects that `class-properties` assumption
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 21, 2025
…2417) * close rolldown/rolldown#5326 Regression introduced by #12212. The transform execution shift causes the bug because the `class-properties` plugin always assumes that all fields accessed can be transformed. However, the prior change breaks the assumption. This PR reverts some changes to remove the ts-only field early, which respects that `class-properties` assumption
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 21, 2025
…2417) * close rolldown/rolldown#5326 Regression introduced by #12212. The transform execution shift causes the bug because the `class-properties` plugin always assumes that all fields accessed can be transformed. However, the prior change breaks the assumption. This PR reverts some changes to remove the ts-only field early, which respects that `class-properties` assumption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Input:
Before output:
After output:
The
declarefields with decorators should be transformed, but they would be removed in the typescript plugin before legacy decorators transform them, so this PR is to adjust the transform order and allowdeclarefields can be transformed