Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jul 16, 2025

declare const IS_PROD: boolean; if (IS_PROD) {}
-> declare const IS_PROD: boolean; {}

fixes rolldown/rolldown#5251

@github-actions github-actions bot added the C-bug Category - Bug label Jul 16, 2025
Copy link
Member Author

Boshen commented Jul 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen self-assigned this Jul 16, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 16, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 16, 2025

CodSpeed Instrumentation Performance Report

Merging #12312 will not alter performance

Comparing 07-16-fix_transformer_plugins_replace_global_defines_handle_declare_const_ (b172cef) with main (e82f758)

Summary

✅ 34 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 16, 2025

Merge activity

…t` (#12312)

`declare const IS_PROD: boolean; if (IS_PROD) {}`
-> `declare const IS_PROD: boolean; {}`

fixes rolldown/rolldown#5251
@graphite-app graphite-app bot force-pushed the 07-16-fix_transformer_plugins_replace_global_defines_handle_declare_const_ branch from a0981ad to b172cef Compare July 16, 2025 04:03
@graphite-app graphite-app bot merged commit b172cef into main Jul 16, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 16, 2025
@graphite-app graphite-app bot deleted the 07-16-fix_transformer_plugins_replace_global_defines_handle_declare_const_ branch July 16, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: define replacement does not work when identifier is declared via declare const

2 participants