Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jul 17, 2025

Remove function calls where the function is empty:

  • function foo() {} foo() -> ``
  • `var foo = () => {}; foo() -> ``
  • function foo() {} x = foo(a, b) -> x = (a, b, void 0)

closes #11469

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Jul 17, 2025
Copy link
Member Author

Boshen commented Jul 17, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen marked this pull request as draft July 17, 2025 15:52
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 17, 2025

CodSpeed Instrumentation Performance Report

Merging #12373 will not alter performance

Comparing 07-17-feat_minifier_remove_empty_functions (998c67b) with main (8bae417)

Summary

✅ 34 untouched benchmarks

@Boshen Boshen force-pushed the 07-17-feat_minifier_remove_empty_functions branch 2 times, most recently from 7f7d4a4 to 533b691 Compare July 20, 2025 08:36
@Boshen Boshen marked this pull request as ready for review July 20, 2025 08:36
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 20, 2025
Copy link
Member Author

Boshen commented Jul 20, 2025

Merge activity

Remove function calls where the function is empty:

* `function foo() {} foo()` -> ``
* `var foo = () => {}; foo() -> ``
* `function foo() {} x = foo(a, b)` -> `x = (a, b, void 0)`

closes #11469
@graphite-app graphite-app bot force-pushed the 07-17-feat_minifier_remove_empty_functions branch from 533b691 to 998c67b Compare July 20, 2025 12:59
@graphite-app graphite-app bot merged commit 998c67b into main Jul 20, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 20, 2025
@graphite-app graphite-app bot deleted the 07-17-feat_minifier_remove_empty_functions branch July 20, 2025 13:06
github-merge-queue bot pushed a commit to rolldown/rolldown that referenced this pull request Jul 20, 2025
This upgrade adds

* oxc-project/oxc#12353
* oxc-project/oxc#12373
* oxc-project/oxc#12393
* oxc-project/oxc#12394
* oxc-project/oxc#12398
* oxc-project/oxc-sourcemap#86

We should expect a small performance improvement when sourcemap is
enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minifier: remove no-op function call

2 participants