Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 22, 2025

Binder::bind has a no-op default implementation that is meaningless, so remove it.

@github-actions github-actions bot added A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 22, 2025
Copy link
Member Author

Dunqing commented Jul 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing marked this pull request as ready for review July 22, 2025 06:49
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 22, 2025

CodSpeed Instrumentation Performance Report

Merging #12447 will not alter performance

Comparing 07-22-refactor_semantic_remove_redundant_default_implementation_for_binder_binder (2874ec4) with main (9a9d78d)

Summary

✅ 34 untouched benchmarks

@Dunqing Dunqing requested a review from Boshen July 23, 2025 10:23
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
Copy link
Member

Boshen commented Jul 23, 2025

Merge activity

…er::binder` (#12447)

`Binder::bind` has a no-op default implementation that is meaningless, so remove it.
@graphite-app graphite-app bot force-pushed the 07-22-refactor_semantic_remove_redundant_default_implementation_for_binder_binder branch from 357016a to 2874ec4 Compare July 23, 2025 13:53
@graphite-app graphite-app bot merged commit 2874ec4 into main Jul 23, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
@graphite-app graphite-app bot deleted the 07-22-refactor_semantic_remove_redundant_default_implementation_for_binder_binder branch July 23, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants