feat(transformer, minifier, syntax)!: remove ESTarget::ES5
#12448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-transformer
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12448 will not alter performanceComparing Summary
|
Dunqing
force-pushed
the
07-22-feat_transformer_minifier_syntax_remove_estarget_es5
branch
from
0f47c56 to
cfb871f
Compare
Dunqing
changed the title
ESTarget::ES5ESTarget::ES5
Dunqing
force-pushed
the
07-22-feat_transformer_minifier_syntax_remove_estarget_es5
branch
from
cfb871f to
01ac487
Compare
Member
Merge activity
|
* close #11296 Both `Transformer` and `Minifier` have a minimum ES version support of `ES2015`. However, we can set the `ESTarget` to `ES5` now, which might mislead users into thinking we already support `ES5`, so for now, let's remove the `ESTarget::ES5` option to eliminate the confusion. Suggested by @shulaoda
graphite-app
bot
force-pushed
the
07-22-feat_transformer_minifier_syntax_remove_estarget_es5
branch
from
2c7fc8a to
ccbcf3e
Compare
graphite-app
bot
deleted the
07-22-feat_transformer_minifier_syntax_remove_estarget_es5
branch
camchenry
pushed a commit
that referenced
this pull request
Jul 26, 2025
* close #11296 Both `Transformer` and `Minifier` have a minimum ES version support of `ES2015`. However, we can set the `ESTarget` to `ES5` now, which might mislead users into thinking we already support `ES5`, so for now, let's remove the `ESTarget::ES5` option to eliminate the confusion. Suggested by @shulaoda
camchenry
pushed a commit
that referenced
this pull request
Jul 26, 2025
* close #11296 Both `Transformer` and `Minifier` have a minimum ES version support of `ES2015`. However, we can set the `ESTarget` to `ES5` now, which might mislead users into thinking we already support `ES5`, so for now, let's remove the `ESTarget::ES5` option to eliminate the confusion. Suggested by @shulaoda
camchenry
pushed a commit
that referenced
this pull request
Jul 26, 2025
* close #11296 Both `Transformer` and `Minifier` have a minimum ES version support of `ES2015`. However, we can set the `ESTarget` to `ES5` now, which might mislead users into thinking we already support `ES5`, so for now, let's remove the `ESTarget::ES5` option to eliminate the confusion. Suggested by @shulaoda
camchenry
pushed a commit
that referenced
this pull request
Jul 26, 2025
* close #11296 Both `Transformer` and `Minifier` have a minimum ES version support of `ES2015`. However, we can set the `ESTarget` to `ES5` now, which might mislead users into thinking we already support `ES5`, so for now, let's remove the `ESTarget::ES5` option to eliminate the confusion. Suggested by @shulaoda
camchenry
pushed a commit
that referenced
this pull request
Jul 27, 2025
* close #11296 Both `Transformer` and `Minifier` have a minimum ES version support of `ES2015`. However, we can set the `ESTarget` to `ES5` now, which might mislead users into thinking we already support `ES5`, so for now, let's remove the `ESTarget::ES5` option to eliminate the confusion. Suggested by @shulaoda
camchenry
pushed a commit
that referenced
this pull request
Aug 7, 2025
* close #11296 Both `Transformer` and `Minifier` have a minimum ES version support of `ES2015`. However, we can set the `ESTarget` to `ES5` now, which might mislead users into thinking we already support `ES5`, so for now, let's remove the `ESTarget::ES5` option to eliminate the confusion. Suggested by @shulaoda
Boshen
pushed a commit
that referenced
this pull request
Aug 7, 2025
* close #11296 Both `Transformer` and `Minifier` have a minimum ES version support of `ES2015`. However, we can set the `ESTarget` to `ES5` now, which might mislead users into thinking we already support `ES5`, so for now, let's remove the `ESTarget::ES5` option to eliminate the confusion. Suggested by @shulaoda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESTarget::ES5#11296Both
TransformerandMinifierhave a minimum ES version support ofES2015. However, we can set theESTargettoES5now, which might mislead users into thinking we already supportES5, so for now, let's remove theESTarget::ES5option to eliminate the confusion.Suggested by @shulaoda