Skip to content

fix(linter/require-await): improve async keyword detection in get_delete_span function #12494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

fix(linter/require-await): improve async keyword detection in get_delete_span function #12494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions crates/oxc_linter/src/rules/eslint/require_await.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,14 @@ impl Rule for RequireAwait {

#[expect(clippy::cast_possible_truncation)]
fn get_delete_span(ctx: &LintContext, start: u32) -> Span {
let end = start + 5;
let async_key_span = Span::new(start, end);
let source_text = ctx.source_text();
let source_from_start = &source_text[(start as usize)..];

// Find the position of "async" keyword from the start position
let async_pos = source_from_start.find("async").unwrap_or(0);
let async_start = start + async_pos as u32;
let async_end = async_start + 5;
let async_key_span = Span::new(async_start, async_end);

// debug assertions
#[cfg(debug_assertions)]
Expand All @@ -173,7 +179,7 @@ fn get_delete_span(ctx: &LintContext, start: u32) -> Span {
}

let mut offset: u32 = 0;
for c in ctx.source_text()[(end as usize)..].chars() {
for c in ctx.source_text()[(async_end as usize)..].chars() {
if !c.is_whitespace() {
break;
}
Expand Down Expand Up @@ -304,6 +310,7 @@ fn test() {
),
("async function O(){r}", "function O(){r}"),
("s={expoí:async function(){{}}}", "s={expoí:function(){{}}}"),
("class foo { private async bar() { x() } }", "class foo { private bar() { x() } }"),
];

Tester::new(RequireAwait::NAME, RequireAwait::PLUGIN, pass, fail)
Expand Down
Loading