Skip to content

refactor(diagnostics): implement Eq and Ord for InfoPosition #12505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

refactor(diagnostics): implement Eq and Ord for InfoPosition #12505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions apps/oxlint/src/output_formatter/default.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,15 +134,7 @@ mod test_implementation {

self.diagnostics.sort_by_cached_key(|diagnostic| {
let info = Info::new(diagnostic);
(
info.filename,
info.start.line,
info.start.column,
info.end.line,
info.end.column,
info.rule_id,
info.message,
)
(info.filename, info.start, info.end, info.rule_id, info.message)
});

for diagnostic in &self.diagnostics {
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_diagnostics/src/reporter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ pub struct Info {
pub rule_id: Option<String>,
}

#[derive(Debug)]
#[derive(PartialEq, Eq, PartialOrd, Ord, Debug)]
pub struct InfoPosition {
pub line: usize,
pub column: usize,
Expand Down
Loading