Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jul 25, 2025

closes #11469

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 25, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-minifier Area - Minifier A-ast Area - AST C-enhancement Category - New feature or request labels Jul 25, 2025
@Boshen Boshen force-pushed the remove-assignment-expr branch from 0a96f97 to 10b8464 Compare July 25, 2025 01:42
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 25, 2025

CodSpeed Instrumentation Performance Report

Merging #12509 will degrade performances by 3.48%

Comparing remove-assignment-expr (23f7f82) with main (209d006)1

Summary

❌ 2 regressions
✅ 32 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
minifier[binder.ts] 4.7 ms 4.8 ms -3.48%
minifier[cal.com.tsx] 37.6 ms 38.8 ms -3.07%

Footnotes

  1. No successful run was found on main (66eaa2e) during the generation of this report, so 209d006 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen force-pushed the remove-assignment-expr branch from 10b8464 to 6f626c6 Compare July 25, 2025 13:11
@github-actions github-actions bot added the A-codegen Area - Code Generation label Jul 25, 2025
@Boshen Boshen force-pushed the remove-assignment-expr branch 2 times, most recently from d53f57a to 194e873 Compare July 25, 2025 13:25
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 25, 2025
Copy link
Member Author

Boshen commented Jul 25, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the remove-assignment-expr branch from 194e873 to 23f7f82 Compare July 25, 2025 15:53
@graphite-app graphite-app bot merged commit 23f7f82 into main Jul 25, 2025
24 checks passed
@graphite-app graphite-app bot deleted the remove-assignment-expr branch July 25, 2025 16:01
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-codegen Area - Code Generation A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minifier: remove no-op function call

2 participants