Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 25, 2025

Pure style refactor:

  • Use == instead of matches! when matching a single variant.
  • Reformat multi-line matches! blocks.

(found this old branch lying around from March which I'd never got around to submitting)

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 25, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 25, 2025 16:06
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 25, 2025

CodSpeed Instrumentation Performance Report

Merging #12520 will not alter performance

Comparing 03-25-style_lexer_reformat_kind_matchers (977d3ba) with main (23f7f82)

Summary

✅ 34 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 25, 2025
Copy link
Member

Boshen commented Jul 25, 2025

Merge activity

Pure style refactor:

* Use `==` instead of `matches!` when matching a single variant.
* Reformat multi-line `matches!` blocks.

(found this old branch lying around from March which I'd never got around to submitting)
@graphite-app graphite-app bot force-pushed the 03-25-style_lexer_reformat_kind_matchers branch from 006373e to 977d3ba Compare July 25, 2025 16:15
@graphite-app graphite-app bot merged commit 977d3ba into main Jul 25, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 03-25-style_lexer_reformat_kind_matchers branch July 25, 2025 16:23
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants